Two fixes to NamedTuple pattern matching #22953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
odersky
commented
Apr 9, 2025
- Fix translation for named patterns where the selector is a single-element named tuple. We used to take the whole tuple as result (which is correct for unnamed patterns) but for named patterns we have to select the field instead.
- Take account of named patterns in the refutability check.
1. Fix translation for named patterns where the selector is a single-element
named tuple. We used to take the whole tuple as result (which is correct
for unnamed patterns) but for named patterns we have to select the field
instead.
2. Take account of named patterns in the refutability check.
|
Fixes #22900 |
|
It would be nice if we could ship this in 3.7.0 RC3, since
But only if it does not hold up the release. |
sjrd
requested changes
Apr 10, 2025
There was a problem hiding this comment.
Implementation looks good.
It seems the tests were intended to have check files (they println things rather than assert), but there are no checkfiles.
|
Now also fixes #22899 |
sjrd
approved these changes
Apr 10, 2025
WojciechMazur
added a commit
that referenced
this pull request
Apr 14, 2025
Backports #22953 to the 3.7.0-RC2. PR submitted by the release tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.