Skip to content

⚠️ CI failed on Wheel builder (last failure: Apr 28, 2025) ⚠️ #31257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scikit-learn-bot opened this issue Apr 27, 2025 · 4 comments · Fixed by #31263
Closed

⚠️ CI failed on Wheel builder (last failure: Apr 28, 2025) ⚠️ #31257

scikit-learn-bot opened this issue Apr 27, 2025 · 4 comments · Fixed by #31263
Labels
Bug free-threading PRs and issues related to support for free-threaded CPython (a.k.a. nogil or no-GIL, PEP 703)

Comments

@scikit-learn-bot
Copy link
Contributor

scikit-learn-bot commented Apr 27, 2025

CI is still failing on Wheel builder (Apr 28, 2025)

@github-actions github-actions bot added the Needs Triage Issue requires triage label Apr 27, 2025
@scikit-learn-bot scikit-learn-bot changed the title ⚠️ CI failed on Wheel builder (last failure: Apr 27, 2025) ⚠️ ⚠️ CI failed on Wheel builder (last failure: Apr 28, 2025) ⚠️ Apr 28, 2025
@ogrisel ogrisel added free-threading PRs and issues related to support for free-threaded CPython (a.k.a. nogil or no-GIL, PEP 703) and removed Needs Triage Issue requires triage labels Apr 28, 2025
@ogrisel
Copy link
Member

ogrisel commented Apr 28, 2025

The nightly CI has discovered a Cython-related problem on all the free-threading builds:

   _______________ ERROR collecting utils/tests/test_cython_blas.py _______________
  ImportError while importing test module '/tmp/tmp.O8xqw5JN27/venv/lib/python3.13t/site-packages/sklearn/utils/tests/test_cython_blas.py'.
  Hint: make sure your test modules/packages have valid Python names.
  Traceback:
  /opt/_internal/cpython-3.13.3-nogil/lib/python3.13t/importlib/__init__.py:88: in import_module
      return _bootstrap._gcd_import(name[level:], package, level)
  ../venv/lib/python3.13t/site-packages/sklearn/utils/tests/test_cython_blas.py:4: in <module>
      from sklearn.utils._cython_blas import (
  E   ImportError: cannot import name 'ColMajor' from 'sklearn.utils._cython_blas' (/tmp/tmp.O8xqw5JN27/venv/lib/python3.13t/site-packages/sklearn/utils/_cython_blas.cpython-313t-x86_64-linux-gnu.so)

@ogrisel ogrisel added the Bug label Apr 28, 2025
@ogrisel
Copy link
Member

ogrisel commented Apr 28, 2025

ColMajor comes from:

cpdef enum BLAS_Order:
RowMajor # C contiguous
ColMajor # Fortran contiguous

@ogrisel
Copy link
Member

ogrisel commented Apr 28, 2025

I am not sure exactly what caused this build to start failing 2 days ago. Here is the history of the runs:

https://github.com/scikit-learn/scikit-learn/actions/workflows/wheels.yml?query=branch%3Amain+event%3Aschedule

@ogrisel
Copy link
Member

ogrisel commented Apr 28, 2025

In the last successful run and the rist failing run, the Python versions were both:

3.13.2 experimental free-threading build (main, Mar 22 2025, 16:18:34) [GCC 10.2.1 20210130 (Red Hat 10.2.1-11)]

and the wheel was built with:

     Successfully installed Cython-3.1.0b1 meson-1.8.0rc2 meson-python-0.17.1 numpy-2.3.0.dev0 packaging-25.0 pyproject-metadata-0.9.1 scipy-1.16.0.dev0

in both cases. Maybe it's a side effect of a change in SciPy?

Anyway the fix in #31263 seems legit and I wonder why Cython does not complain at build time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug free-threading PRs and issues related to support for free-threaded CPython (a.k.a. nogil or no-GIL, PEP 703)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants