Skip to content

BUG: for several datasets, download_if_missing keyword was ignored. #7944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2016
Merged

BUG: for several datasets, download_if_missing keyword was ignored. #7944

merged 1 commit into from
Nov 29, 2016

Conversation

rgommers
Copy link
Contributor

Do what is promised in the docstring (raise an IOError), if download_if_missing=False and the dataset wasn't previously downloaded.

@agramfort
Copy link
Member

LGTM but can you look why CIs are not happy?

@rgommers
Copy link
Contributor Author

LGTM but can you look why CIs are not happy?

A combination of me being asleep and running the tests for the wrong version of sklearn, and 2 tests being a bit odd with checking for a particular error code. Fixed now.

tguillemot
tguillemot approved these changes Nov 28, 2016
View reviewed changes
sklearn/datasets/tests/test_covtype.py
if e.errno == errno.ENOENT:
raise SkipTest("Covertype dataset can not be loaded.")
except IOError:
raise SkipTest("Covertype dataset can not be loaded.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agramfort I know it's an old code but why use a SkipTest rather than an assert_raise_message ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't know whether the call will succeed, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. Thanks for the clarification and sorry for the misunderstanding @amueller.

@tguillemot
Copy link
Contributor

LGTM despite the SkipTest :)

@amueller
Copy link
Member

regression test would be checking that we get an IOError if the file does not exist, right? Might be a bit overkill? Otherwise LGTM.

@TomDLT
Copy link
Member

TomDLT commented Nov 29, 2016

LGTM

@amueller amueller merged commit 63583fe into scikit-learn:master Nov 29, 2016
@amueller
Copy link
Member

uh that needs a whatsnew. Anyone wanna have a go?

@rgommers rgommers deleted the dowload-if-missing branch November 29, 2016 18:55
@rgommers
Copy link
Contributor Author

You mean a mention under "bug fixes" in doc/whats_new.rst? I can send a new PR for that.

@amueller
Copy link
Member

indeed. Thanks :)

@rgommers rgommers mentioned this pull request Nov 29, 2016
Merged
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
@rgommers @sergeyf
BUG: for several datasets, download_if_missing keyword was ignore…
86cee5c 
…d. (scikit-learn#7944)
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@rgommers @Sundrique
BUG: for several datasets, download_if_missing keyword was ignore…
45a0f2b 
…d. (scikit-learn#7944)
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@rgommers @NelleV
BUG: for several datasets, download_if_missing keyword was ignore…
99cccd0 
…d. (scikit-learn#7944)
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@rgommers @paulha
BUG: for several datasets, download_if_missing keyword was ignore…
a8b4a18 
…d. (scikit-learn#7944)
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@rgommers @maskani-moh
BUG: for several datasets, download_if_missing keyword was ignore…
72085ff 
…d. (scikit-learn#7944)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller left review comments

@tguillemot tguillemot tguillemot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rgommers @agramfort @tguillemot @amueller @TomDLT