-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[WIP] Balanced Random Forest #8732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you provide a summary of what exactly is left to do in the PR description? Thanks! |
@massich check out my branch feature/balanced-random-forest-api. The changes are:
Please let me know what is left to get this merged. |
@potash I am benchmarking the estimator here. My idea for the benchmark is:
|
Sounds good. You'll want to merge |
There's some benchmarks here on a real datasets and also a silly implementation of the feature using imblearn: https://github.com/amueller/applied_ml_spring_2017/blob/master/slides/aml-15-resampling-imbalanced-data.ipynb |
Hello there, is it possible to get an update on this? We're using this model in production (https://github.com/Chicago/lead-model), and as we prepare to go live it would be very helpful for deployment if this branch were in the standard sci-kit learn library. Thanks for all the great work here! Also, let us know if there's something we can do to move this forward. |
this needs tests, documentation and examples. I'm a big fan of this methods, so I'd be happy to see this moved forward. @massich are you still working on it? Would you like some help? |
In the meanwhile, we have the BalancedBaggingClassifier which can be set to a balanced random forest by setting |
@glemaitre I believe you are right. |
Actually, it completely stalled. I did not even finish the benchmark. I was playing with openml but I didn't finish it. It has been sitting for 6 months. We should definitely revive it. |
IMO it would be good if you helped complete this, @chkoar |
@chkoar let me know if there's anything I (original author of the feature) can do to help. Would be very happy to see this merged. |
@potash ok, thanks. Let's hope that it will be merged during the upcoming sprint. |
I think you should expect a little less. But let's honours list hope it will be a lot closer to merge after the sprint. |
Reference Issue
Fixes #8607
What does this implement/fix? Explain your changes.
This PR takes over #5181 ( and #8728 )
What does this implement/fix? Explain your changes.
Tasks to be performed
balanced=True
that triggers the BRF