MAINT make sure canonical link is https://scikit-learn.org #28487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
commented
Feb 20, 2024
| @@ -20,7 +20,7 @@ | |||
| {% block htmltitle %} | |||
| <title>{{ title|striptags|e }}{{ titlesuffix }}</title> | |||
| {% endblock %} | |||
| <link rel="canonical" href="http://scikit-learn.org/stable/{{pagename}}.html" /> | |||
| <link rel="canonical" href="https://scikit-learn.org/stable/{{pagename}}.html" /> | |||
There was a problem hiding this comment.
This is actually what seems to bother the Algolia's crawler.
|
ping @adrinjalali @ogrisel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #28478, it seems that Algolia find that the canonical link is
http://scikit-learn.orgthat does not match the landing page.So I corrected the canonical link in
layout.html. In addition, I make the other links in the documentation to matchhttps.