Use BLAS_Order.ColMajor sklearn/utils/_cython_blas.pyx #31263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this PR seems to fix the original problem, but then I have the feeling that we are running into a deadlock later. |
50747fb to
3e74b36
Compare
…e-threaded] build
3e74b36 to
339e422
Compare
ogrisel
commented
Apr 28, 2025
| @@ -88,6 +88,7 @@ jobs: | |||
| DISTRIB: 'conda-free-threaded' | |||
| LOCK_FILE: './build_tools/azure/pylatest_free_threaded_linux-64_conda.lock' | |||
| COVERAGE: 'false' | |||
| SKLEARN_FAULTHANDLER_TIMEOUT: '1800' # 30 * 60 seconds | |||
There was a problem hiding this comment.
The usual duration for the pylatest_free_threaded run is below 20 min, so 30 minutes should give a large enough margin to avoid false positives.
|
The deadlock did not happen with the last commit, but if it happens again in the future, we should get more information to track down the cause of the problem, or at least point us to the test that is related to a potential race-condition. |
adrinjalali
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #31257.
I also had a linter warning when editing this file in my IDE prior to making the changes in this PR.
I wonder why this problem would be free-threading specific though.