Skip to content

Commit 03c722f

Browse files
committed
Making an internal method more private
1 parent e047b7f commit 03c722f

File tree

3 files changed

+18
-47
lines changed

3 files changed

+18
-47
lines changed

java/client/src/org/openqa/selenium/remote/BUCK

-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ java_library(name = 'remote-lib',
7474
'BeanToJsonConverter.java',
7575
'CommandCodec.java',
7676
'CommandInfo.java',
77-
'CoordinatesUtils.java',
7877
'Dialect.java',
7978
'DriverCommand.java',
8079
'ErrorCodes.java',

java/client/src/org/openqa/selenium/remote/CoordinatesUtils.java

-41
This file was deleted.

java/client/src/org/openqa/selenium/remote/RemoteTouchScreen.java

+18-5
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717

1818
package org.openqa.selenium.remote;
1919

20+
import com.google.common.collect.Maps;
21+
2022
import org.openqa.selenium.interactions.TouchScreen;
2123
import org.openqa.selenium.interactions.internal.Coordinates;
2224

@@ -32,7 +34,7 @@ public RemoteTouchScreen(ExecuteMethod executeMethod) {
3234
}
3335

3436
public void singleTap(Coordinates where) {
35-
Map<String, Object> singleTapParams = CoordinatesUtils.paramsFromCoordinates(where);
37+
Map<String, Object> singleTapParams = paramsFromCoordinates(where);
3638
executeMethod.execute(DriverCommand.TOUCH_SINGLE_TAP, singleTapParams);
3739
}
3840

@@ -58,19 +60,19 @@ public void move(int x, int y) {
5860
}
5961

6062
public void scroll(Coordinates where, int xOffset, int yOffset) {
61-
Map<String, Object> scrollParams = CoordinatesUtils.paramsFromCoordinates(where);
63+
Map<String, Object> scrollParams = paramsFromCoordinates(where);
6264
scrollParams.put("xoffset", xOffset);
6365
scrollParams.put("yoffset", yOffset);
6466
executeMethod.execute(DriverCommand.TOUCH_SCROLL, scrollParams);
6567
}
6668

6769
public void doubleTap(Coordinates where) {
68-
Map<String, Object> doubleTapParams = CoordinatesUtils.paramsFromCoordinates(where);
70+
Map<String, Object> doubleTapParams = paramsFromCoordinates(where);
6971
executeMethod.execute(DriverCommand.TOUCH_DOUBLE_TAP, doubleTapParams);
7072
}
7173

7274
public void longPress(Coordinates where) {
73-
Map<String, Object> longPressParams = CoordinatesUtils.paramsFromCoordinates(where);
75+
Map<String, Object> longPressParams = paramsFromCoordinates(where);
7476
executeMethod.execute(DriverCommand.TOUCH_LONG_PRESS, longPressParams);
7577
}
7678

@@ -89,10 +91,21 @@ public void flick(int xSpeed, int ySpeed) {
8991
}
9092

9193
public void flick(Coordinates where, int xOffset, int yOffset, int speed) {
92-
Map<String, Object> flickParams = CoordinatesUtils.paramsFromCoordinates(where);
94+
Map<String, Object> flickParams = paramsFromCoordinates(where);
9395
flickParams.put("xoffset", xOffset);
9496
flickParams.put("yoffset", yOffset);
9597
flickParams.put("speed", speed);
9698
executeMethod.execute(DriverCommand.TOUCH_FLICK, flickParams);
9799
}
100+
101+
private static Map<String, Object> paramsFromCoordinates(Coordinates where) {
102+
Map<String, Object> params = Maps.newHashMap();
103+
104+
if (where != null) {
105+
String id = (String) where.getAuxiliary();
106+
params.put("element", id);
107+
}
108+
109+
return params;
110+
}
98111
}

0 commit comments

Comments
 (0)