Skip to content

Commit 18beade

Browse files
committed
[java] allow ignoring chromedriver build checks using service builders
1 parent 3e146d0 commit 18beade

File tree

2 files changed

+24
-2
lines changed

2 files changed

+24
-2
lines changed

java/src/org/openqa/selenium/chrome/ChromeDriverService.java

+12-1
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ public static ChromeDriverService createServiceWithConfig(ChromeOptions options)
154154
public static class Builder extends DriverService.Builder<
155155
ChromeDriverService, ChromeDriverService.Builder> {
156156

157-
private final boolean disableBuildCheck = Boolean.getBoolean(CHROME_DRIVER_DISABLE_BUILD_CHECK);
157+
private boolean disableBuildCheck = Boolean.getBoolean(CHROME_DRIVER_DISABLE_BUILD_CHECK);
158158
private boolean appendLog = Boolean.getBoolean(CHROME_DRIVER_APPEND_LOG_PROPERTY);
159159
private boolean verbose = Boolean.getBoolean(CHROME_DRIVER_VERBOSE_LOG_PROPERTY);
160160
private boolean silent = Boolean.getBoolean(CHROME_DRIVER_SILENT_OUTPUT_PROPERTY);
@@ -187,6 +187,17 @@ public Builder withAppendLog(boolean appendLog) {
187187
return this;
188188
}
189189

190+
/**
191+
* Allows the driver to be used with potentially incompatible versions of the browser.
192+
*
193+
* @param noBuildCheck True for not enforcing matching versions.
194+
* @return A self reference.
195+
*/
196+
public Builder withBuildCheckDisabled(boolean noBuildCheck) {
197+
this.disableBuildCheck = noBuildCheck;
198+
return this;
199+
}
200+
190201
/**
191202
* Configures the driver server verbosity.
192203
*

java/src/org/openqa/selenium/edge/EdgeDriverService.java

+12-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public static EdgeDriverService createDefaultService() {
123123
public static class Builder extends DriverService.Builder<
124124
EdgeDriverService, Builder> {
125125

126-
private final boolean disableBuildCheck = Boolean.getBoolean(EDGE_DRIVER_DISABLE_BUILD_CHECK);
126+
private boolean disableBuildCheck = Boolean.getBoolean(EDGE_DRIVER_DISABLE_BUILD_CHECK);
127127
private boolean appendLog = Boolean.getBoolean(EDGE_DRIVER_APPEND_LOG_PROPERTY);
128128
private boolean verbose = Boolean.getBoolean(EDGE_DRIVER_VERBOSE_LOG_PROPERTY);
129129
private String logLevel = System.getProperty(EDGE_DRIVER_LOG_LEVEL_PROPERTY);
@@ -161,6 +161,17 @@ public Builder withAppendLog(boolean appendLog) {
161161
return this;
162162
}
163163

164+
/**
165+
* Allows the driver to be used with potentially incompatible versions of the browser.
166+
*
167+
* @param noBuildCheck True for not enforcing matching versions.
168+
* @return A self reference.
169+
*/
170+
public Builder withBuildCheckDisabled(boolean noBuildCheck) {
171+
this.disableBuildCheck = noBuildCheck;
172+
return this;
173+
}
174+
164175
/**
165176
* Configures the driver server verbosity.
166177
*

0 commit comments

Comments
 (0)