Skip to content

Commit 2cc2ecf

Browse files
committed
Show desired effect in javadoc
Unfortunately, <blink> tags are no longer supported by most browsers. Fortunately, modern CSS has got our back, in this throwback to the spooky way the web used to be.
1 parent a63ed1d commit 2cc2ecf

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

Rakefile

+19
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,7 @@ ie_generate_type_mapping(:name => "ie_result_type_java",
327327

328328

329329
task :javadocs => [:'repack-jetty', :common, :firefox, :ie, :remote, :support, :chrome, :selenium] do
330+
rm_rf "build/javadoc"
330331
mkdir_p "build/javadoc"
331332
sourcepath = ""
332333
classpath = '.'
@@ -339,6 +340,7 @@ task :javadocs => [:'repack-jetty', :common, :firefox, :ie, :remote, :support, :
339340
[File.join(%w(java server src))].each do |m|
340341
sourcepath += File::PATH_SEPARATOR + m
341342
end
343+
342344
p sourcepath
343345
cmd = "javadoc -notimestamp -d build/javadoc -sourcepath #{sourcepath} -classpath #{classpath} -subpackages org.openqa.selenium -subpackages com.thoughtworks "
344346
cmd << " -exclude org.openqa.selenium.internal.selenesedriver:org.openqa.selenium.internal.seleniumemulation:org.openqa.selenium.remote.internal"
@@ -347,6 +349,23 @@ task :javadocs => [:'repack-jetty', :common, :firefox, :ie, :remote, :support, :
347349
cmd = cmd.gsub(/\//, "\\").gsub(/:/, ";")
348350
end
349351
sh cmd
352+
353+
File.open("build/javadoc/stylesheet.css", "a") { |file| file.write(<<EOF
354+
355+
/* Custom selenium-specific styling */
356+
.blink {
357+
animation: 2s cubic-bezier(0.5, 0, 0.85, 0.85) infinite blink;
358+
}
359+
360+
@keyframes blink {
361+
50% {
362+
opacity: 0;
363+
}
364+
}
365+
366+
EOF
367+
)
368+
}
350369
end
351370

352371
task :py_prep_for_install_release => [

java/client/src/org/openqa/selenium/Beta.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
* be relied upon. The update policy for anything marked beta is that it may be
2929
* deleted in the next Selenium release without warning.
3030
*
31-
* In the ideal world, this would cause the method to blink gently in the user's
31+
* In the ideal world, this would cause the method to <span class="blink">blink gently</span> in the user's
3232
* IDE. We don't live in the ideal world. We'll find out the hard way whether
3333
* reading docs is the same thing.
3434
*/

0 commit comments

Comments
 (0)