Skip to content

Commit 2ef07a7

Browse files
asashourbarancev
authored andcommitted
Fix generics warnings
Signed-off-by: Alexei Barantsev <[email protected]>
1 parent 3a1d5e9 commit 2ef07a7

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

java/client/src/org/openqa/selenium/ImmutableCapabilities.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ private void abbreviate(
145145
Map<?, ?> m = (Map<?, ?>) stringify;
146146
int length = m.size();
147147
int i = 0;
148-
for (Map.Entry entry : m.entrySet()) {
148+
for (Map.Entry<?, ?> entry : m.entrySet()) {
149149
abbreviate(seen, value, entry.getKey());
150150
value.append("=");
151151
abbreviate(seen, value, entry.getValue());

java/client/src/org/openqa/selenium/support/events/EventFiringWebDriver.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -275,10 +275,10 @@ private Object wrapResult(Object result) {
275275
return new EventFiringWebElement((WebElement) result);
276276
}
277277
if (result instanceof List) {
278-
return ((List) result).stream().map(this::wrapResult).collect(Collectors.toList());
278+
return ((List<?>) result).stream().map(this::wrapResult).collect(Collectors.toList());
279279
}
280280
if (result instanceof Map) {
281-
return ((Map<String, Object>) result).entrySet().stream().collect(
281+
return ((Map<?, ?>) result).entrySet().stream().collect(
282282
HashMap::new,
283283
(m, e) -> m.put(e.getKey(), e.getValue()),
284284
Map::putAll);

java/client/test/org/openqa/selenium/interactions/ActionsTest.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ public void creatingAllMouseActions() {
154154
order.verifyNoMoreInteractions();
155155
}
156156

157-
@SuppressWarnings("unchecked")
157+
@SuppressWarnings({"unchecked", "rawtypes"})
158158
@Test
159159
public void testCtrlClick() {
160160
WebDriver driver = mock(WebDriver.class, withSettings().extraInterfaces(Interactive.class));
@@ -173,9 +173,9 @@ public void testCtrlClick() {
173173
assertEquals(2, sequence.size());
174174

175175
// get mouse and keyboard sequences
176-
Map[] sequencesJson = sequence.stream().map(Sequence::toJson).toArray(HashMap[]::new);
177-
Map mouseSequence = sequencesJson[0];
178-
Map keyboardSequence;
176+
Map<String, Object>[] sequencesJson = sequence.stream().map(Sequence::toJson).toArray(HashMap[]::new);
177+
Map<String, Object> mouseSequence = sequencesJson[0];
178+
Map<String, Object> keyboardSequence;
179179
if (!mouseSequence.get("type").equals("pointer")) {
180180
mouseSequence = sequencesJson[1];
181181
keyboardSequence = sequencesJson[0];

0 commit comments

Comments
 (0)