Fixed the code pointed out by rubocop.

Signed-off-by: Alex Rodionov <[email protected]>

Author: RustyNail

rb/lib/selenium/webdriver/common/html5/shared_web_storage.rb

@@ -40,7 +40,7 @@ def empty?
         def each
           return enum_for(:each) unless block_given?
 
-          keys.each do |k|
+          keys.each do |k| # rubocop:disable Performance/HashEachMethods
             yield k, self[k]
           end
         end

rb/lib/selenium/webdriver/common/proxy.rb

@@ -37,7 +37,7 @@ class Proxy
                  socks_username: 'socksUsername',
                  socks_password: 'socksPassword'}.freeze
 
-      ALLOWED.keys.each { |t| attr_reader t }
+      ALLOWED.each_key { |t| attr_reader t }
 
       def self.json_create(data)
         data['proxyType'] = data['proxyType'].downcase.to_sym

rb/lib/selenium/webdriver/firefox/profile.rb

@@ -189,8 +189,6 @@ def proxy=(proxy)
           else
             raise ArgumentError, "unsupported proxy type #{proxy.type}"
           end
-
-          proxy
         end
 
         def encoded

rb/lib/selenium/webdriver/ie/options.rb

@@ -40,7 +40,7 @@ class Options
           validate_cookie_document_type: 'ie.validateCookieDocumentType'
         }.freeze
 
-        CAPABILITIES.keys.each do |key|
+        CAPABILITIES.each_key do |key|
           define_method key do
             @options[key]
           end

rb/lib/selenium/webdriver/remote/bridge.rb

@@ -169,7 +169,7 @@ def execute(command, opts = {}, command_hash = nil)
         end
 
         def escaper
-          @escaper ||= defined?(URI::Parser) ? URI::Parser.new : URI
+          @escaper ||= defined?(URI::Parser) ? URI::DEFAULT_PARSER : URI
         end
 
         def commands(command)

rb/lib/selenium/webdriver/remote/http/default.rb

@@ -24,7 +24,7 @@ module Remote
       module Http
         # @api private
         class Default < Common
-          attr_accessor :proxy
+          attr_writer :proxy
 
           attr_accessor :open_timeout
           attr_accessor :read_timeout

rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb

@@ -61,13 +61,13 @@ module WebDriver
           path = Firefox::Binary.path
 
           create_driver! do |driver|
-            default_version = driver.capabilities.version
+            @default_version = driver.capabilities.version
             expect { driver.capabilities.browser_version }.to_not raise_exception
           end
 
           caps = Remote::Capabilities.firefox(firefox_options: {binary: ENV['ALT_FIREFOX_BINARY']})
           create_driver!(desired_capabilities: caps) do |driver|
-            expect(driver.capabilities.version).to_not eql(default_version)
+            expect(driver.capabilities.version).to_not eql(@default_version)
             expect { driver.capabilities.browser_version }.to_not raise_exception
           end
         ensure
@@ -82,14 +82,14 @@ module WebDriver
           path = Firefox::Binary.path
 
           create_driver! do |driver|
-            default_version = driver.capabilities.version
+            @default_version = driver.capabilities.version
             expect { driver.capabilities.browser_version }.to_not raise_exception
           end
 
           caps = Remote::Capabilities.firefox(firefox_options: {binary: ENV['ALT_FIREFOX_BINARY']},
                                               service_args: {binary: path})
           create_driver!(desired_capabilities: caps) do |driver|
-            expect(driver.capabilities.version).to_not eql(default_version)
+            expect(driver.capabilities.version).to_not eql(@default_version)
             expect { driver.capabilities.browser_version }.to_not raise_exception
           end
         ensure