Fixing IE stale element detection for parent elements.

When calling element.findElement(s), if the parent element is stale, the
IE driver was returning an "invalid argument" error. The W3C
specification mandates that "stale element reference" is the correct
error. Fixes issue #5700.

Author: jimevans

cpp/iedriver/CommandHandlers/FindChildElementCommandHandler.cpp

@@ -101,7 +101,8 @@ void FindChildElementCommandHandler::ExecuteInternal(
         return;
       }
       if (status_code == ENOSUCHWINDOW) {
-        response->SetErrorResponse(ERROR_NO_SUCH_WINDOW, "Unable to find element on closed window");
+        response->SetErrorResponse(ERROR_NO_SUCH_WINDOW, 
+                                   "Unable to find element on closed window");
         return;
       }
       if (status_code != ENOSUCHELEMENT) {
@@ -117,8 +118,13 @@ void FindChildElementCommandHandler::ExecuteInternal(
     response->SetErrorResponse(ERROR_NO_SUCH_ELEMENT, 
         "Unable to find element with " + mechanism + " == " + value);
   } else {
-    response->SetErrorResponse(ERROR_INVALID_ARGUMENT, "Element is no longer valid");
-    return;
+    if (status_code == EOBSOLETEELEMENT) {
+      response->SetErrorResponse(ERROR_STALE_ELEMENT_REFERENCE,
+                                 "Specified parent element is no longer attached to the DOM");
+    } else {
+      response->SetErrorResponse(ERROR_INVALID_ARGUMENT,
+                                 "Element is no longer valid");
+    }
   }
 }
 

cpp/iedriver/CommandHandlers/FindChildElementsCommandHandler.cpp

@@ -101,7 +101,8 @@ void FindChildElementsCommandHandler::ExecuteInternal(
           return;
         }
       } else if (status_code == ENOSUCHWINDOW) {
-        response->SetErrorResponse(ERROR_NO_SUCH_WINDOW, "Unable to find elements on closed window");
+        response->SetErrorResponse(ERROR_NO_SUCH_WINDOW, 
+                                   "Unable to find elements on closed window");
         return;
       } else {
         response->SetErrorResponse(status_code, found_elements.asString());
@@ -121,7 +122,13 @@ void FindChildElementsCommandHandler::ExecuteInternal(
           "returned an unexpected error");
     }
   } else {
-    response->SetErrorResponse(ERROR_INVALID_ARGUMENT, "Element is no longer valid");
+    if (status_code == EOBSOLETEELEMENT) {
+      response->SetErrorResponse(ERROR_STALE_ELEMENT_REFERENCE,
+                                 "Specified parent element is no longer attached to the DOM");
+    } else {
+      response->SetErrorResponse(ERROR_INVALID_ARGUMENT,
+                                 "Element is no longer valid");
+    }
   }
 }
 

cpp/iedriverserver/CHANGELOG

@@ -9,6 +9,11 @@ available via the project downloads page. Changes in "revision" field indicate
 private releases checked into the prebuilts directory of the source tree, but
 not made generally available on the downloads page.
 
+v3.11.1.4
+=========
+ * Fixed finding child elements to return proper error if parent element is
+   stale. Fixes issue #5700.
+
 v3.11.1.3
 =========
  * Fixed detection of obscured elements when top element is not displayed.

cpp/iedriverserver/IEDriverServer.rc

@@ -50,8 +50,8 @@ END
 //
 
 VS_VERSION_INFO VERSIONINFO
- FILEVERSION 3,11,1,3
- PRODUCTVERSION 3,11,1,3
+ FILEVERSION 3,11,1,4
+ PRODUCTVERSION 3,11,1,4
  FILEFLAGSMASK 0x3fL
 #ifdef _DEBUG
  FILEFLAGS 0x1L
@@ -68,12 +68,12 @@ BEGIN
         BEGIN
             VALUE "CompanyName", "Software Freedom Conservancy"
             VALUE "FileDescription", "Command line server for the IE driver"
-            VALUE "FileVersion", "3.11.1.3"
+            VALUE "FileVersion", "3.11.1.4"
             VALUE "InternalName", "IEDriverServer.exe"
             VALUE "LegalCopyright", "Copyright (C) 2017"
             VALUE "OriginalFilename", "IEDriverServer.exe"
             VALUE "ProductName", "Selenium WebDriver"
-            VALUE "ProductVersion", "3.11.1.3"
+            VALUE "ProductVersion", "3.11.1.4"
         END
     END
     BLOCK "VarFileInfo"