Skip to content

Commit 4854ccb

Browse files
committed
Move Handlers under the commandhandlers package
1 parent bb73a56 commit 4854ccb

File tree

6 files changed

+14
-8
lines changed

6 files changed

+14
-8
lines changed

java/server/src/org/openqa/selenium/remote/server/AllHandlers.java

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import org.openqa.selenium.remote.JsonToBeanConverter;
2929
import org.openqa.selenium.remote.SessionId;
3030
import org.openqa.selenium.remote.http.HttpMethod;
31+
import org.openqa.selenium.remote.server.commandhandler.BeginSession;
3132
import org.openqa.selenium.remote.server.commandhandler.GetAllSessions;
3233
import org.openqa.selenium.remote.server.commandhandler.GetLogTypes;
3334
import org.openqa.selenium.remote.server.commandhandler.GetLogsOfType;

java/server/src/org/openqa/selenium/remote/server/BUCK

-2
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,8 @@ java_library(
7070
'ActiveSessionFactory.java',
7171
'ActiveSessionListener.java',
7272
'ActiveSessions.java',
73-
'BeginSession.java',
7473
'AllHandlers.java',
7574
'CommandHandler.java',
76-
'ExceptionHandler.java',
7775
'InMemorySession.java',
7876
'Passthrough.java',
7977
'ProtocolConverter.java',

java/server/src/org/openqa/selenium/remote/server/WebDriverServlet.java

+1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929

3030
import org.openqa.selenium.logging.LoggingHandler;
3131
import org.openqa.selenium.remote.SessionId;
32+
import org.openqa.selenium.remote.server.commandhandler.ExceptionHandler;
3233
import org.openqa.selenium.remote.server.log.LoggingManager;
3334
import org.openqa.selenium.remote.server.log.PerSessionLogHandler;
3435
import org.openqa.selenium.remote.server.xdrpc.CrossDomainRpc;

java/server/src/org/openqa/selenium/remote/server/BeginSession.java renamed to java/server/src/org/openqa/selenium/remote/server/commandhandler/BeginSession.java

+7-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18-
package org.openqa.selenium.remote.server;
18+
package org.openqa.selenium.remote.server.commandhandler;
1919

2020
import static com.google.common.net.MediaType.JSON_UTF_8;
2121
import static java.net.HttpURLConnection.HTTP_OK;
@@ -30,14 +30,19 @@
3030
import org.openqa.selenium.remote.CapabilityType;
3131
import org.openqa.selenium.remote.http.HttpRequest;
3232
import org.openqa.selenium.remote.http.HttpResponse;
33+
import org.openqa.selenium.remote.server.ActiveSession;
34+
import org.openqa.selenium.remote.server.ActiveSessionFactory;
35+
import org.openqa.selenium.remote.server.ActiveSessions;
36+
import org.openqa.selenium.remote.server.CommandHandler;
37+
import org.openqa.selenium.remote.server.NewSessionPayload;
3338
import org.openqa.selenium.remote.server.log.LoggingManager;
3439

3540
import java.io.IOException;
3641
import java.io.InputStreamReader;
3742
import java.io.Reader;
3843
import java.util.logging.Level;
3944

40-
class BeginSession implements CommandHandler {
45+
public class BeginSession implements CommandHandler {
4146

4247
private final ActiveSessionFactory sessionFactory;
4348
private final ActiveSessions allSessions;

java/server/src/org/openqa/selenium/remote/server/ExceptionHandler.java renamed to java/server/src/org/openqa/selenium/remote/server/commandhandler/ExceptionHandler.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18-
package org.openqa.selenium.remote.server;
18+
package org.openqa.selenium.remote.server.commandhandler;
1919

2020
import static com.google.common.net.MediaType.JSON_UTF_8;
2121
import static java.net.HttpURLConnection.HTTP_INTERNAL_ERROR;
@@ -29,6 +29,7 @@
2929
import org.openqa.selenium.remote.ErrorCodes;
3030
import org.openqa.selenium.remote.http.HttpRequest;
3131
import org.openqa.selenium.remote.http.HttpResponse;
32+
import org.openqa.selenium.remote.server.CommandHandler;
3233

3334
import java.util.HashMap;
3435
import java.util.Map;
@@ -39,7 +40,7 @@
3940
* Takes an exception and formats it for a local end that speaks either the OSS or W3C dialect of
4041
* the wire protocol.
4142
*/
42-
class ExceptionHandler implements CommandHandler {
43+
public class ExceptionHandler implements CommandHandler {
4344

4445
private final static ErrorCodes ERRORS = new ErrorCodes();
4546
private final static BeanToJsonConverter toJson = new BeanToJsonConverter();

java/server/test/org/openqa/selenium/remote/server/ExceptionHandlerTest.java renamed to java/server/test/org/openqa/selenium/remote/server/commandhandler/ExceptionHandlerTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,8 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18-
package org.openqa.selenium.remote.server;
18+
package org.openqa.selenium.remote.server.commandhandler;
1919

20-
import static java.net.HttpURLConnection.HTTP_BAD_REQUEST;
2120
import static java.net.HttpURLConnection.HTTP_INTERNAL_ERROR;
2221
import static org.junit.Assert.assertEquals;
2322

@@ -32,6 +31,7 @@
3231
import org.openqa.selenium.remote.http.HttpMethod;
3332
import org.openqa.selenium.remote.http.HttpRequest;
3433
import org.openqa.selenium.remote.http.HttpResponse;
34+
import org.openqa.selenium.remote.server.commandhandler.ExceptionHandler;
3535

3636
import java.lang.reflect.Type;
3737
import java.util.Map;

0 commit comments

Comments
 (0)