Deprecating environment setting in FirefoxBinary, it should be configured in DriverService (for local runs) on in server/node settings (for remote runs)

Author: barancev

java/client/src/org/openqa/selenium/firefox/FirefoxBinary.java

@@ -24,6 +24,7 @@
 import static org.openqa.selenium.Platform.UNIX;
 import static org.openqa.selenium.Platform.WINDOWS;
 import static org.openqa.selenium.os.WindowsUtils.getPathsInProgramFiles;
+import org.openqa.selenium.remote.service.DriverService;
 
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.Iterables;
@@ -138,6 +139,19 @@ public FirefoxBinary(File pathToFirefoxBinary) {
     executable = new Executable(pathToFirefoxBinary);
   }
 
+  /**
+   * deprecated Use {@link DriverService.Builder#withEnvironment(Map)} instead:
+   * <p>
+   * new FirefoxDriver(
+   *   new GeckoDriverService.Builder()
+   *     .usingDriverExecutable(new File("path/to/geckodriver.exe"))
+   *     .usingFirefoxBinary(new FirefoxBinary(new File("path/to/firefox.exe")))
+   *     .withEnvironment(ImmutableMap.of("DISPLAY", "0:0"))
+   *     .build());
+   * @param propertyName
+   * @param value
+   */
+  @Deprecated
   public void setEnvironmentProperty(String propertyName, String value) {
     if (propertyName == null || value == null) {
       throw new WebDriverException(
@@ -206,6 +220,10 @@ protected String getPath() {
     return executable.getPath();
   }
 
+  /**
+   * @deprecated No replacement. Environment should be configured in {@link DriverService} instance.
+   */
+  @Deprecated
   public Map<String, String> getExtraEnv() {
     return Collections.unmodifiableMap(extraEnv);
   }