Added java 8 lambda expressions and also did some code cleanup of catching multiple exceptions in single catch block

Added java 8 lambda expressions in below classes

AddFindsByCss
AddFindsChildByCss
AddRemoteTouchScreen
AddRotatable
RemoteWebElement

and also did some code cleanup of catching multiple exceptions in single catch block  in below class,

JsonToBeanConverter

Signed-off-by: Simon Stewart <[email protected]>

Author: gs-athaduka

java/client/src/org/openqa/selenium/remote/AddFindsByCss.java

@@ -18,7 +18,6 @@
 package org.openqa.selenium.remote;
 
 import com.google.common.collect.ImmutableMap;
-
 import org.openqa.selenium.WebDriverException;
 import org.openqa.selenium.internal.FindsByCssSelector;
 

java/client/src/org/openqa/selenium/remote/AddFindsChildByCss.java

@@ -18,7 +18,6 @@
 package org.openqa.selenium.remote;
 
 import com.google.common.collect.ImmutableMap;
-
 import org.openqa.selenium.WebDriverException;
 import org.openqa.selenium.internal.FindsByCssSelector;
 

java/client/src/org/openqa/selenium/remote/AddRotatable.java

@@ -18,13 +18,12 @@
 package org.openqa.selenium.remote;
 
 import com.google.common.collect.ImmutableMap;
-
 import org.openqa.selenium.DeviceRotation;
 import org.openqa.selenium.Rotatable;
 import org.openqa.selenium.ScreenOrientation;
 
 public class AddRotatable implements AugmenterProvider {
-    
+
   public Class<?> getDescribedInterface() {
     return Rotatable.class;
   }
@@ -47,7 +46,7 @@ public InterfaceImplementation getImplementation(Object value) {
           response = ScreenOrientation.valueOf((String) executeMethod.execute(DriverCommand.GET_SCREEN_ORIENTATION, null));
           break;
         case "rotation":
-          response = (DeviceRotation) executeMethod.execute(DriverCommand.GET_SCREEN_ROTATION, null);
+          response = executeMethod.execute(DriverCommand.GET_SCREEN_ROTATION, null);
           break;
         default:
           throw new IllegalArgumentException(method.getName() + ", Not defined in rotatable interface");

java/client/src/org/openqa/selenium/remote/RemoteWebElement.java

@@ -204,10 +204,7 @@ protected List<WebElement> findElements(String using, String value) {
     } catch (ClassCastException ex) {
       throw new WebDriverException("Returned value cannot be converted to List<WebElement>: " + responseValue, ex);
     }
-    for (WebElement element : allElements) {
-      parent.setFoundBy(this, element, using, value);
-    }
-
+    allElements.forEach(element -> parent.setFoundBy(this, element, using, value));
     return allElements;
   }
 

java/client/src/org/openqa/selenium/remote/SessionId.java

@@ -37,9 +37,6 @@ public int hashCode() {
 
   @Override
   public boolean equals(Object obj) {
-    if (obj instanceof SessionId) {
-      return opaqueKey.equals(((SessionId) obj).opaqueKey);
-    }
-    return false;
+    return obj instanceof SessionId && opaqueKey.equals(((SessionId) obj).opaqueKey);
   }
 }