@@ -119,7 +119,7 @@ public static class Builder extends DriverService.Builder<
119
119
120
120
private final boolean disableBuildCheck = Boolean .getBoolean (EDGE_DRIVER_DISABLE_BUILD_CHECK );
121
121
private boolean verbose = Boolean .getBoolean (EDGE_DRIVER_VERBOSE_LOG_PROPERTY );
122
- private String loglevel = System .getProperty (EDGE_DRIVER_LOG_LEVEL_PROPERTY );
122
+ private String logLevel = System .getProperty (EDGE_DRIVER_LOG_LEVEL_PROPERTY );
123
123
private boolean silent = Boolean .getBoolean (EDGE_DRIVER_SILENT_OUTPUT_PROPERTY );
124
124
private String allowedListIps = System .getProperty (EDGE_DRIVER_ALLOWED_IPS_PROPERTY );
125
125
@@ -150,15 +150,20 @@ public int score(Capabilities capabilities) {
150
150
* @return A self reference.
151
151
*/
152
152
public EdgeDriverService .Builder withVerbose (boolean verbose ) {
153
- this .verbose = verbose ;
153
+ if (verbose ) {
154
+ this .logLevel = "ALL" ;
155
+ }
156
+ this .verbose = false ;
154
157
return this ;
155
158
}
156
159
157
160
/**
158
161
* Configures the driver server log level.
159
162
*/
160
- public EdgeDriverService .Builder withLoglevel (String level ) {
161
- this .loglevel = level ;
163
+ public EdgeDriverService .Builder withLoglevel (String logLevel ) {
164
+ this .verbose = false ;
165
+ this .silent = false ;
166
+ this .logLevel = logLevel ;
162
167
return this ;
163
168
}
164
169
@@ -169,7 +174,10 @@ public EdgeDriverService.Builder withLoglevel(String level) {
169
174
* @return A self reference.
170
175
*/
171
176
public EdgeDriverService .Builder withSilent (boolean silent ) {
172
- this .silent = silent ;
177
+ if (silent ) {
178
+ this .logLevel = "OFF" ;
179
+ }
180
+ this .silent = false ;
173
181
return this ;
174
182
}
175
183
@@ -202,19 +210,21 @@ protected List<String> createArgs() {
202
210
}
203
211
}
204
212
213
+ // If set in properties and not overwritten by method
214
+ if (verbose ) {
215
+ withVerbose (true );
216
+ }
217
+ if (silent ) {
218
+ withSilent (true );
219
+ }
220
+
205
221
List <String > args = new ArrayList <>();
206
222
args .add (String .format ("--port=%d" , getPort ()));
207
223
if (getLogFile () != null ) {
208
224
args .add (String .format ("--log-path=%s" , getLogFile ().getAbsolutePath ()));
209
225
}
210
- if (verbose ) {
211
- args .add ("--verbose" );
212
- }
213
- if (silent ) {
214
- args .add ("--silent" );
215
- }
216
- if (loglevel != null ) {
217
- args .add (String .format ("--log-level=%s" , loglevel ));
226
+ if (logLevel != null ) {
227
+ args .add (String .format ("--log-level=%s" , logLevel ));
218
228
}
219
229
if (allowedListIps != null ) {
220
230
args .add (String .format ("--whitelisted-ips=%s" , allowedListIps ));
0 commit comments