Skip to content

Commit 5d83293

Browse files
committed
Remove platformVersion from W3C payload
Closes #4641 and #4644
1 parent 5cb47df commit 5d83293

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

rb/lib/selenium/webdriver/remote/w3c/capabilities.rb

+9-8
Original file line numberDiff line numberDiff line change
@@ -35,29 +35,32 @@ module W3C
3535
# @api private
3636
#
3737

38-
# TODO - uncomment when Mozilla fixes this:
39-
# https://bugzilla.mozilla.org/show_bug.cgi?id=1326397
4038
class Capabilities
4139

4240
EXTENSION_CAPABILITY_PATTERN = /\A[\w-]+:.*\z/
4341

44-
# TODO (alex): compare with spec
4542
KNOWN = [
4643
:browser_name,
4744
:browser_version,
4845
:platform_name,
49-
:platform_version,
5046
:accept_insecure_certs,
5147
:page_load_strategy,
5248
:proxy,
49+
:set_window_rect,
50+
:timeouts,
51+
:unhandled_prompt_behavior,
52+
53+
# remote-specific
5354
:remote_session_id,
55+
56+
# TODO (alex): deprecate in favor of Firefox::Options?
5457
:accessibility_checks,
5558
:device,
59+
60+
# TODO (alex): deprecate compatibility with OSS-capabilities
5661
:implicit_timeout,
5762
:page_load_timeout,
5863
:script_timeout,
59-
:unhandled_prompt_behavior,
60-
:timeouts,
6164
].freeze
6265

6366
KNOWN.each do |key|
@@ -114,7 +117,6 @@ def json_create(data)
114117
caps.browser_name = data.delete('browserName')
115118
caps.browser_version = data.delete('browserVersion')
116119
caps.platform_name = data.delete('platformName')
117-
caps.platform_version = data.delete('platformVersion')
118120
caps.accept_insecure_certs = data.delete('acceptInsecureCerts') if data.key?('acceptInsecureCerts')
119121
caps.page_load_strategy = data.delete('pageLoadStrategy')
120122
timeouts = data.delete('timeouts')
@@ -196,7 +198,6 @@ def from_oss(oss_capabilities)
196198
# @option :browser_name [String] required browser name
197199
# @option :browser_version [String] required browser version number
198200
# @option :platform_name [Symbol] one of :any, :win, :mac, or :x
199-
# @option :platform_version [String] required platform version number
200201
# @option :accept_insecure_certs [Boolean] does the driver accept insecure SSL certifications?
201202
# @option :proxy [Selenium::WebDriver::Proxy, Hash] proxy configuration
202203
#

0 commit comments

Comments
 (0)