[grid] Catch exception in local distributor that was preventing nodes being added

Author: shs96c

java/server/src/org/openqa/selenium/grid/distributor/local/LocalDistributor.java

@@ -64,6 +64,7 @@
 import java.util.concurrent.locks.ReadWriteLock;
 import java.util.concurrent.locks.ReentrantReadWriteLock;
 import java.util.function.Supplier;
+import java.util.logging.Level;
 import java.util.logging.Logger;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
@@ -274,6 +275,8 @@ boolean allBucketsSameSize(Map<String, Set<Host>> hostBuckets) {
   private void refresh(NodeStatus status) {
     Objects.requireNonNull(status);
 
+    LOG.fine("Refreshing: " + status.getUri());
+
     // Iterate over the available nodes to find a match.
     Lock writeLock = lock.writeLock();
     writeLock.lock();
@@ -282,12 +285,13 @@ private void refresh(NodeStatus status) {
           .filter(host -> host.getId().equals(status.getNodeId()))
           .findFirst();
 
-
       if (existing.isPresent()) {
         // Modify the state
+        LOG.fine("Modifying existing state");
         existing.get().update(status);
       } else {
         // No match made. Add a new host.
+        LOG.info("Creating a new remote node for " + status.getUri());
         Node node = new RemoteNode(
             tracer,
             clientFactory,
@@ -316,7 +320,10 @@ private LocalDistributor add(Node node, NodeStatus status) {
 
       Host host = new Host(bus, node);
       host.update(status);
+
+      LOG.fine("Adding host: " + host.asSummary());
       hosts.add(host);
+
       LOG.info(String.format("Added node %s.", node.getId()));
       host.runHealthCheck();
 
@@ -325,6 +332,8 @@ private LocalDistributor add(Node node, NodeStatus status) {
       nodeRunnables.add(runnable);
       allChecks.put(node.getId(), nodeRunnables);
       hostChecker.submit(runnable, Duration.ofMinutes(5), Duration.ofSeconds(30));
+    } catch (Throwable t) {
+      LOG.log(Level.WARNING, "Unable to process host", t);
     } finally {
       writeLock.unlock();
     }