[js] Removed the WebDriver.prototype.call() method. This was used to inject

custom function calls into the control flow. Now that the promise manager is
no longer used, this method is no longer necessary. Users are now responsible
for coordinating actions (ideally with async functions) and can just call
functions directly instead of through `driver.call()`.

Author: jleyba

javascript/node/selenium-webdriver/CHANGES.md

@@ -35,6 +35,11 @@ mode.
 *  Removed the 'opera' module
 *  Removed the `WebDriver.attachToSession()` factory method. Users can just use
    use the `WebDriver` constructor directly instead.
+*  Removed the `WebDriver.prototype.call()` method. This was used to inject
+   custom function calls into the control flow. Now that the promise manager is
+   no longer used, this method is no longer necessary. Users are now responsible
+   for coordinating actions (ideally with async functions) and can just call
+   functions directly instead of through `driver.call()`.
 *  Removed the `WebDriver.prototype.touchActions()` method. Action sequences
    are now defined from a single origin: `WebDriver.prototype.actions()`.
 *  Removed the promise manager from `lib/promise`, which includes the removal

javascript/node/selenium-webdriver/lib/webdriver.js

@@ -382,18 +382,6 @@ class IWebDriver {
    */
   executeAsyncScript(script, ...args) {}
 
-  /**
-   * Executes a custom function.
-   *
-   * @param {function(...): (T|IThenable<T>)} fn The function to execute.
-   * @param {Object=} scope The object in whose scope to execute the function.
-   * @param {...*} args Any arguments to pass to the function.
-   * @return {!IThenable<T>} A promise that will be resolved' with the
-   *     function's result.
-   * @template T
-   */
-  call(fn, scope = undefined, ...args) {}
-
   /**
    * Waits for a condition to evaluate to a "truthy" value. The condition may be
    * specified by a {@link Condition}, as a custom function, or as any
@@ -758,13 +746,6 @@ class WebDriver {
             setParameter('args', args));
   }
 
-  /** @override */
-  call(fn, scope = undefined, ...args) {
-    return promise.fullyResolved(args).then(function(args) {
-      return fn.apply(scope, args);
-    });
-  }
-
   /** @override */
   wait(condition, timeout = 0, message = undefined) {
     if (typeof timeout !== 'number' || timeout < 0) {

javascript/node/selenium-webdriver/test/lib/webdriver_test.js

@@ -398,146 +398,6 @@ describe('WebDriver', function() {
     });
   });
 
-  describe('customFunctions', function() {
-    it('returnsANonPromiseValue', function() {
-      var driver = new FakeExecutor().createDriver();
-      return driver.call(() => 'abc123').then(function(value) {
-        assert.equal('abc123', value);
-      });
-    });
-
-    it('passingArgumentsToACustomFunction', function() {
-      var add = function(a, b) {
-        return a + b;
-      };
-      var driver = new FakeExecutor().createDriver();
-      return driver.call(add, null, 1, 2).then(function(value) {
-        assert.equal(3, value);
-      });
-    });
-
-    it('passingPromisedArgumentsToACustomFunction', function() {
-      var promisedArg = Promise.resolve(2);
-      var add = function(a, b) {
-        return a + b;
-      };
-      var driver = new FakeExecutor().createDriver();
-      return driver.call(add, null, 1, promisedArg).then(function(value) {
-        assert.equal(3, value);
-      });
-    });
-
-    it('passingArgumentsAndScopeToACustomFunction', function() {
-      function Foo(name) {
-        this.name = name;
-      }
-      Foo.prototype.getName = function() {
-        return this.name;
-      };
-      var foo = new Foo('foo');
-
-      var driver = new FakeExecutor().createDriver();
-      return driver.call(foo.getName, foo).then(function(value) {
-        assert.equal('foo', value);
-      });
-    });
-
-    it('customFunctionThrowsAnError', function() {
-      var driver = new FakeExecutor().createDriver();
-      return driver.call(throwStubError).then(fail, assertIsStubError);
-    });
-
-    it('returnsATaskResultAfterSchedulingAnother', function() {
-      let executor = new FakeExecutor().
-          expect(CName.GET_TITLE).
-              andReturnSuccess('Google Search').
-          expect(CName.CLOSE).
-          end();
-
-      var driver = executor.createDriver();
-      return driver.call(function() {
-        var title = driver.getTitle();
-        driver.close();
-        return title;
-      }).then(function(title) {
-        assert.equal('Google Search', title);
-      });
-    });
-
-    it('hasANestedCommandThatFails', function() {
-      let executor = new FakeExecutor().
-          expect(CName.SWITCH_TO_WINDOW, {
-            'name': 'foo',
-            'handle': 'foo'
-          }).
-          andReturnError(new StubError()).
-          end();
-
-      var driver = executor.createDriver();
-      return driver.call(function() {
-        return driver.switchTo().window('foo');
-      }).then(fail, assertIsStubError);
-    });
-
-    it('returnsADeferredAction', function() {
-      let executor = new FakeExecutor().
-          expect(CName.GET_TITLE).andReturnSuccess('Google').
-          end();
-
-      var driver = executor.createDriver();
-      driver.call(function() {
-        return driver.getTitle();
-      }).then(function(title) {
-        assert.equal('Google', title);
-      });
-    });
-  });
-
-  describe('nestedCommands', function() {
-    it('canReturnValueFromNestedFunction', function() {
-      var driver = new FakeExecutor().createDriver();
-      return driver.call(function() {
-        return driver.call(function() {
-          return driver.call(() => 'foobar');
-        });
-      }).then(function(value) {
-        assert.equal('foobar', value);
-      });
-    });
-
-    it('errorsBubbleUp_caught', function() {
-      var driver = new FakeExecutor().createDriver();
-      return driver.call(function() {
-        return driver.call(function() {
-          return driver.call(throwStubError);
-        });
-      }).then(fail, assertIsStubError);
-    });
-
-    it('errorsBubbleUp_uncaught', function() {
-      var driver = new FakeExecutor().createDriver();
-      return driver.call(function() {
-        return driver.call(function() {
-          return driver.call(throwStubError);
-        });
-      })
-      .then(_ => assert.fail('should have failed'), assertIsStubError);
-    });
-
-    it('canScheduleCommands', function() {
-      let executor = new FakeExecutor().
-          expect(CName.GET_TITLE).
-          expect(CName.CLOSE).
-          end();
-
-      var driver = executor.createDriver();
-      return driver.call(function() {
-        return driver.call(() => driver.getTitle())
-            .then(() => driver.close());
-      });
-    });
-  });
-
   describe('WebElementPromise', function() {
     let driver = new FakeExecutor().createDriver();
 

javascript/node/selenium-webdriver/test/upload_test.js

@@ -63,11 +63,9 @@ test.suite(function(env) {
 
     await driver.get(Pages.uploadPage);
 
-    var fp = await driver.call(function() {
-      return io.tmpFile().then(function(fp) {
-        fs.writeFileSync(fp, FILE_HTML);
-        return fp;
-      });
+    var fp = await io.tmpFile().then(function(fp) {
+      fs.writeFileSync(fp, FILE_HTML);
+      return fp;
     });
 
     await driver.findElement(By.id('upload')).sendKeys(fp);