[java] fix bug for appium subclass that sets neither log file nor out… (#12696)

titusfortner · web-flow · commit 6ff7f5491bb4 · 2023-09-16T06:54:19.000-05:00
[java] fix bug for appium subclass that sets neither log file nor output stream
diff --git a/java/src/org/openqa/selenium/remote/service/DriverService.java b/java/src/org/openqa/selenium/remote/service/DriverService.java
@@ -444,8 +444,12 @@ protected Duration getDefaultTimeout() {
     }
 
     protected OutputStream getLogOutput() {
+      if (logOutputStream != null) {
+        return logOutputStream;
+      }
       try {
-        return logOutputStream != null ? logOutputStream : new FileOutputStream(logFile);
+        File logFile = getLogFile();
+        return logFile == null ? ByteStreams.nullOutputStream() : new FileOutputStream(logFile);
       } catch (FileNotFoundException e) {
         throw new RuntimeException(e);
       }

Original file line number	Diff line number	Diff line change
`@@ -444,8 +444,12 @@ protected Duration getDefaultTimeout() {`
`444`	`444`	`}`
`445`	`445`
`446`	`446`	`protected OutputStream getLogOutput() {`
	`447`	`+ if (logOutputStream != null) {`
	`448`	`+ return logOutputStream;`
	`449`	`+ }`
`447`	`450`	`try {`
`448`		`- return logOutputStream != null ? logOutputStream : new FileOutputStream(logFile);`
	`451`	`+ File logFile = getLogFile();`
	`452`	`+ return logFile == null ? ByteStreams.nullOutputStream() : new FileOutputStream(logFile);`
`449`	`453`	`} catch (FileNotFoundException e) {`
`450`	`454`	`throw new RuntimeException(e);`
`451`	`455`	`}`