Skip to content

Commit 74831e4

Browse files
committed
Deprecating EdgeDriver constructors that accept Capabilities, it's recommended to use EdgeOptions
1 parent bf05c46 commit 74831e4

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

java/client/src/org/openqa/selenium/edge/EdgeDriver.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,9 @@ public EdgeDriver(EdgeDriverService service) {
113113
*
114114
* @param capabilities The capabilities required from the EdgeDriver.
115115
* @see #EdgeDriver(EdgeDriverService, Capabilities)
116+
* @deprecated Use {@link EdgeDriver(EdgeOptions)}
116117
*/
118+
@Deprecated
117119
public EdgeDriver(Capabilities capabilities) {
118120
this(EdgeDriverService.createDefaultService(), capabilities);
119121
}
@@ -136,7 +138,7 @@ public EdgeDriver(EdgeOptions options) {
136138
* @param options The options to use.
137139
*/
138140
public EdgeDriver(EdgeDriverService service, EdgeOptions options) {
139-
this(service, options.toCapabilities());
141+
super(new DriverCommandExecutor(service), options);
140142
}
141143

142144
/**
@@ -145,7 +147,9 @@ public EdgeDriver(EdgeDriverService service, EdgeOptions options) {
145147
*
146148
* @param service The service to use.
147149
* @param capabilities The capabilities required from the EdgeDriver.
150+
* @deprecated Use {@link EdgeDriver(EdgeDriverService, EdgeOptions)}
148151
*/
152+
@Deprecated
149153
public EdgeDriver(EdgeDriverService service, Capabilities capabilities) {
150154
super(new DriverCommandExecutor(service), capabilities);
151155
}

java/client/src/org/openqa/selenium/edge/EdgeOptions.java

+8
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,15 @@
1919

2020
import static org.openqa.selenium.remote.CapabilityType.PAGE_LOAD_STRATEGY;
2121

22+
import com.google.common.collect.ImmutableMap;
23+
2224
import org.openqa.selenium.Capabilities;
2325
import org.openqa.selenium.MutableCapabilities;
2426
import org.openqa.selenium.Platform;
2527
import org.openqa.selenium.remote.BrowserType;
2628
import org.openqa.selenium.remote.CapabilityType;
2729

30+
import java.util.Map;
2831
import java.util.Objects;
2932

3033

@@ -77,4 +80,9 @@ public void setPageLoadStrategy(String strategy) {
7780
MutableCapabilities toCapabilities() {
7881
return this;
7982
}
83+
84+
@Override
85+
public Map<String, ?> asMap() {
86+
return ImmutableMap.of(CAPABILITY, super.asMap());
87+
}
8088
}

0 commit comments

Comments
 (0)