Remove dependency on JNA

This was only used to enable us to forcibly kill processes
on Windows. Java 8 introduced a pure Java way of doing
this, which we now use in preference.

Author: shs96c

.idea/libraries/jna.xml

@@ -11,8 +11,6 @@
 	<classpathentry kind="lib" path="/third-party/java/htmlunit/neko-htmlunit-2.27.jar" sourcepath="/third-party/java/htmlunit/neko-htmlunit-2.27-sources.jar"/>
 	<classpathentry kind="lib" path="/third-party/java/htmlunit/htmlunit-core-js-2.27.jar" sourcepath="/third-party/java/htmlunit/htmlunit-core-js-2.27-sources.jar"/>
 	<classpathentry kind="lib" path="/third-party/java/selenium/htmlunit-driver-2.27.jar" sourcepath="/third-party/java/selenium/htmlunit-driver-2.27.jar"/>
-	<classpathentry kind="lib" path="/third-party/java/jna/jna-4.1.0.jar" sourcepath="/third-party/java/jna/jna-4.1.0-src.jar"/>
-	<classpathentry kind="lib" path="/third-party/java/jna/jna-platform-4.1.0.jar" sourcepath="/third-party/java/jna/jna-platform-4.1.0-src.jar"/>
 	<classpathentry kind="lib" path="/third-party/java/commons/commons-exec-1.3.jar" sourcepath="/third-party/java/commons/commons-exec-1.3-sources.jar"/>
 	<classpathentry kind="lib" path="/third-party/java/jetty/jetty-repacked.jar"/>
 	<classpathentry kind="lib" path="/third-party/java/jetty/jetty-util-9.4.5.v20170502.jar" sourcepath="/third-party/java/jetty/jetty-util-9.4.5.v20170502-sources.jar"/>

java/client/.classpath

@@ -9,7 +9,6 @@ java_library(
     '//java/client/src/org/openqa/selenium/io:io',
     '//third_party/java/commons:commons-exec',
     '//third_party/java/guava:guava',
-    '//third_party/java/jna:jna',
   ],
   visibility = [
     '//java/client/src/org/openqa/selenium:selenium',

java/client/src/org/openqa/selenium/os/BUCK

@@ -54,8 +54,7 @@ class UnixProcess implements OsProcess {
   private final Executor executor = new DaemonExecutor();
 
   private volatile OutputStream drainTo;
-  private SeleniumWatchDog executeWatchdog = new SeleniumWatchDog(
-      ExecuteWatchdog.INFINITE_TIMEOUT);
+  private SeleniumWatchDog executeWatchdog = new SeleniumWatchDog(ExecuteWatchdog.INFINITE_TIMEOUT);
   private PumpStreamHandler streamHandler;
 
   private final org.apache.commons.exec.CommandLine cl;
@@ -148,8 +147,7 @@ public int destroy() {
       return getExitCode();
     }
 
-    log.severe(String.format("Unable to kill process with PID %s",
-                             watchdog.getPID()));
+    log.severe(String.format("Unable to kill process %s", watchdog.process));
     int exitCode = -1;
     executor.setExitValue(exitCode);
     return exitCode;
@@ -236,10 +234,6 @@ public void reset() {
       starting = true;
     }
 
-    private String getPID() {
-      return String.valueOf(ProcessUtils.getProcessId(process));
-    }
-
     private void waitForProcessStarted() {
       while (starting) {
         try {
@@ -262,8 +256,13 @@ private void waitForTerminationAfterDestroy(int duration, TimeUnit unit) {
     }
 
     private void destroyHarder() {
-      ProcessUtils.killProcess(process);
+      try {
+        Process awaitFor = this.process.destroyForcibly();
+        awaitFor.waitFor(10, SECONDS);
+      } catch (InterruptedException e) {
+        Thread.interrupted();
+        throw new RuntimeException(e);
+      }
     }
   }
-
 }