Skip to content

Commit a711f73

Browse files
committed
[java] deprecate setHeadless method on FirefoxOptions
1 parent 7770ad1 commit a711f73

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

java/src/org/openqa/selenium/firefox/FirefoxOptions.java

+5
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,11 @@ public FirefoxOptions setLogLevel(FirefoxDriverLogLevel logLevel) {
252252
return setFirefoxOption(Keys.LOG, logLevel.toJson());
253253
}
254254

255+
/**
256+
* @deprecated Use {@link #addArguments(String...)}.
257+
* Example: `addArguments("-headless")`.
258+
*/
259+
@Deprecated
255260
public FirefoxOptions setHeadless(boolean headless) {
256261
Object rawArgs = firefoxOptions.getOrDefault(Keys.ARGS.key(), new ArrayList<>());
257262
Require.stateCondition(rawArgs instanceof List, "Arg list of unexpected type: %s", rawArgs);

java/test/org/openqa/selenium/firefox/FirefoxDriverTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ public void canSetPageLoadStrategyViaOptions() {
362362
@Test
363363
@NoDriverBeforeTest
364364
public void canStartHeadless() {
365-
localDriver = new FirefoxDriver(new FirefoxOptions().setHeadless(true));
365+
localDriver = new FirefoxDriver(new FirefoxOptions().addArguments("-headless"));
366366

367367
assertThat(((FirefoxDriver) localDriver).getCapabilities().getCapability("moz:headless")).isEqualTo(true);
368368
}

java/test/org/openqa/selenium/firefox/FirefoxOptionsTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,7 @@ void mergingOptionsWithOptionsAsMutableCapabilities() throws IOException {
506506
void firefoxOptionsShouldEqualEquivalentImmutableCapabilities() {
507507
FirefoxOptions
508508
options =
509-
new FirefoxOptions().addArguments("hello").setPageLoadStrategy(EAGER).setHeadless(true);
509+
new FirefoxOptions().addArguments("hello", "-headless").setPageLoadStrategy(EAGER);
510510
Capabilities caps = new ImmutableCapabilities(options);
511511

512512
assertThat(caps).isEqualTo(options);

java/test/org/openqa/selenium/testing/drivers/Browser.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ public Capabilities getCapabilities() {
125125
}
126126

127127
if (Boolean.getBoolean("webdriver.headless")) {
128-
options.setHeadless(true);
128+
options.addArguments("-headless");
129129
}
130130

131131
return options;

0 commit comments

Comments
 (0)