Skip to content

Commit ba13dc3

Browse files
committed
Modify build files so drivers export RemoteWebDriver too
It seems reasonable to assume that if you have code that only depends on `//java/client/src/org/openqa/selenium/firefox` it will compile cleanly without an error being caused by a lack of a reference to `RemoteWebDriver`. However, because Buck only gives first-order dependencies, someone in this position has (until this diff) had to add a reference in their build files to `remote` as well. This is silly, so we now no longer do this.
1 parent 5278a0a commit ba13dc3

File tree

6 files changed

+18
-12
lines changed

6 files changed

+18
-12
lines changed

java/client/src/org/openqa/selenium/chrome/BUCK

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ java_library(
66
maven_coords = 'org.seleniumhq.selenium:selenium-chrome-driver:' + SE_VERSION,
77
maven_pom_template = '//java/client/src/org/openqa/selenium:template-pom',
88
srcs = glob(['*.java']),
9-
deps = [
10-
'//java/client/src/org/openqa/selenium:selenium',
9+
exported_deps = [
1110
'//java/client/src/org/openqa/selenium/remote:remote',
11+
],
12+
deps = [
1213
'//third_party/java/guava:guava',
1314
],
1415
visibility = [ 'PUBLIC' ],

java/client/src/org/openqa/selenium/edge/BUCK

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ java_library(
66
maven_coords = 'org.seleniumhq.selenium:selenium-edge-driver:' + SE_VERSION,
77
maven_pom_template = '//java/client/src/org/openqa/selenium:template-pom',
88
srcs = glob(['*.java']),
9-
deps = [
10-
'//java/client/src/org/openqa/selenium:selenium',
9+
exported_deps = [
1110
'//java/client/src/org/openqa/selenium/remote:remote',
11+
],
12+
deps = [
1213
'//third_party/java/guava:guava',
1314
],
1415
visibility = [ 'PUBLIC' ],

java/client/src/org/openqa/selenium/firefox/BUCK

+3-2
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,11 @@ java_library(name = 'firefox',
1111
':prefs',
1212
':webdriver.xpi',
1313
],
14+
exported_deps = [
15+
'//java/client/src/org/openqa/selenium/remote:remote',
16+
],
1417
deps = [
1518
':prefs',
16-
'//java/client/src/org/openqa/selenium:selenium',
17-
'//java/client/src/org/openqa/selenium/remote:remote',
1819
'//third_party/java/guava:guava',
1920
],
2021
visibility = [ 'PUBLIC' ],

java/client/src/org/openqa/selenium/ie/BUCK

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@ java_library(name = 'ie',
55
maven_coords = 'org.seleniumhq.selenium:selenium-ie-driver:' + SE_VERSION,
66
maven_pom_template = '//java/client/src/org/openqa/selenium:template-pom',
77
srcs = glob(['*.java']),
8-
deps = [
9-
'//java/client/src/org/openqa/selenium:selenium',
8+
exported_deps = [
109
'//java/client/src/org/openqa/selenium/remote:remote',
10+
],
11+
deps = [
1112
'//third_party/java/guava:guava',
1213
],
1314
visibility = [ 'PUBLIC' ],

java/client/src/org/openqa/selenium/opera/BUCK

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ java_library(
66
maven_coords = 'org.seleniumhq.selenium:selenium-opera-driver:' + SE_VERSION,
77
maven_pom_template = '//java/client/src/org/openqa/selenium:template-pom',
88
srcs = glob(['*.java']),
9-
deps = [
10-
'//java/client/src/org/openqa/selenium:selenium',
9+
exported_deps = [
1110
'//java/client/src/org/openqa/selenium/remote:remote',
11+
],
12+
deps = [
1213
'//third_party/java/guava:guava',
1314
],
1415
visibility = [ 'PUBLIC' ],

java/client/src/org/openqa/selenium/safari/BUCK

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@ java_library(name = 'safari',
55
maven_coords = 'org.seleniumhq.selenium:selenium-safari-driver:' + SE_VERSION,
66
maven_pom_template = '//java/client/src/org/openqa/selenium:template-pom',
77
srcs = glob(['*.java']),
8-
deps = [
9-
'//java/client/src/org/openqa/selenium:selenium',
8+
exported_deps = [
109
'//java/client/src/org/openqa/selenium/remote:remote',
10+
],
11+
deps = [
1112
'//third_party/java/guava:guava',
1213
],
1314
visibility = ['PUBLIC'],

0 commit comments

Comments
 (0)