[rb] fix rubocop rspec issues

Author: titusfortner

rb/spec/integration/selenium/webdriver/action_builder_spec.rb

@@ -310,11 +310,11 @@ module WebDriver
           driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
           iframe = driver.find_element(tag_name: 'iframe')
 
-          expect(in_viewport?(iframe)).to eq false
+          expect(in_viewport?(iframe)).to be false
 
           driver.action.scroll_to(iframe).perform
 
-          expect(in_viewport?(iframe)).to eq true
+          expect(in_viewport?(iframe)).to be true
         end
       end
 
@@ -330,7 +330,7 @@ module WebDriver
           driver.action.scroll_by(0, delta_y).perform
           sleep 0.5
 
-          expect(in_viewport?(footer)).to eq true
+          expect(in_viewport?(footer)).to be true
         end
       end
 
@@ -346,7 +346,7 @@ module WebDriver
           driver.switch_to.frame(iframe)
           sleep 0.5
           checkbox = driver.find_element(name: 'scroll_checkbox')
-          expect(in_viewport?(checkbox)).to eq true
+          expect(in_viewport?(checkbox)).to be true
         end
 
         it 'scrolls from element by given amount with offset',
@@ -361,7 +361,7 @@ module WebDriver
           iframe = driver.find_element(tag_name: 'iframe')
           driver.switch_to.frame(iframe)
           checkbox = driver.find_element(name: 'scroll_checkbox')
-          expect(in_viewport?(checkbox)).to eq true
+          expect(in_viewport?(checkbox)).to be true
         end
 
         it 'raises MoveTargetOutOfBoundsError when origin offset from element is out of viewport' do
@@ -384,7 +384,7 @@ module WebDriver
           driver.switch_to.frame(iframe)
           checkbox = driver.find_element(name: 'scroll_checkbox')
           sleep 0.5
-          expect(in_viewport?(checkbox)).to eq true
+          expect(in_viewport?(checkbox)).to be true
         end
 
         it 'raises MoveTargetOutOfBoundsError when origin offset is out of viewport' do

rb/spec/integration/selenium/webdriver/bidi/browsing_context_spec.rb

@@ -28,33 +28,33 @@ class BiDi
 
         it 'can create a browsing context for given id' do
           id = driver.window_handle
-          browsing_context = BrowsingContext.new(driver: driver, browsing_context_id: id)
+          browsing_context = described_class.new(driver: driver, browsing_context_id: id)
           expect(browsing_context.id).to eq(id)
         end
 
         it 'can create a window' do
-          browsing_context = BrowsingContext.new(driver: driver, type: :window)
+          browsing_context = described_class.new(driver: driver, type: :window)
           expect(browsing_context.id).not_to be_nil
         end
 
         it 'can create a window with a reference context' do
-          browsing_context = BrowsingContext.new(driver: driver, type: :window,
+          browsing_context = described_class.new(driver: driver, type: :window,
                                                  reference_context: driver.window_handle)
           expect(browsing_context.id).not_to be_nil
         end
 
         it 'can create a tab' do
-          browsing_context = BrowsingContext.new(driver: driver, type: :tab)
+          browsing_context = described_class.new(driver: driver, type: :tab)
           expect(browsing_context.id).not_to be_nil
         end
 
         it 'can create a tab with a reference context' do
-          browsing_context = BrowsingContext.new(driver: driver, type: :tab, reference_context: driver.window_handle)
+          browsing_context = described_class.new(driver: driver, type: :tab, reference_context: driver.window_handle)
           expect(browsing_context.id).not_to be_nil
         end
 
         it 'can navigate to a url' do
-          browsing_context = BrowsingContext.new(driver: driver, type: :tab)
+          browsing_context = described_class.new(driver: driver, type: :tab)
 
           info = browsing_context.navigate url: url_for('/bidi/logEntryAdded.html')
 
@@ -64,7 +64,7 @@ class BiDi
         end
 
         it 'can navigate to a url with readiness state' do
-          browsing_context = BrowsingContext.new(driver: driver, type: :tab)
+          browsing_context = described_class.new(driver: driver, type: :tab)
 
           info = browsing_context.navigate url: url_for('/bidi/logEntryAdded.html'),
                                            readiness_state: :complete
@@ -76,7 +76,7 @@ class BiDi
 
         it 'can get tree with a child' do
           browsing_context_id = driver.window_handle
-          parent_window = BrowsingContext.new(driver: driver, browsing_context_id: browsing_context_id)
+          parent_window = described_class.new(driver: driver, browsing_context_id: browsing_context_id)
           parent_window.navigate(url: url_for('iframes.html'),
                                  readiness_state: :complete)
 
@@ -88,7 +88,7 @@ class BiDi
 
         it 'can get tree with depth' do
           browsing_context_id = driver.window_handle
-          parent_window = BrowsingContext.new(driver: driver, browsing_context_id: browsing_context_id)
+          parent_window = described_class.new(driver: driver, browsing_context_id: browsing_context_id)
           parent_window.navigate(url: url_for('iframes.html'),
                                  readiness_state: :complete)
 
@@ -98,8 +98,8 @@ class BiDi
         end
 
         it 'can close a window' do
-          window1 = BrowsingContext.new(driver: driver, type: :window)
-          window2 = BrowsingContext.new(driver: driver, type: :window)
+          window1 = described_class.new(driver: driver, type: :window)
+          window2 = described_class.new(driver: driver, type: :window)
 
           window2.close
 

rb/spec/integration/selenium/webdriver/bidi/log_inspector_spec.rb

@@ -30,7 +30,7 @@ class BiDi
         it 'can listen to console log' do
           reset_driver!(web_socket_url: true) do |driver|
             log_entry = nil
-            log_inspector = LogInspector.new(driver)
+            log_inspector = described_class.new(driver)
             log_inspector.on_console_entry { |log| log_entry = log }
 
             driver.navigate.to url_for(@page)
@@ -52,7 +52,7 @@ class BiDi
         it 'can listen to javascript log' do
           reset_driver!(web_socket_url: true) do |driver|
             log_entry = nil
-            log_inspector = LogInspector.new(driver)
+            log_inspector = described_class.new(driver)
             log_inspector.on_javascript_log { |log| log_entry = log }
 
             driver.navigate.to url_for(@page)
@@ -70,7 +70,7 @@ class BiDi
         it 'can listen to javascript error log' do
           reset_driver!(web_socket_url: true) do |driver|
             log_entry = nil
-            log_inspector = LogInspector.new(driver)
+            log_inspector = described_class.new(driver)
             log_inspector.on_javascript_exception { |log| log_entry = log }
 
             driver.navigate.to url_for(@page)
@@ -88,7 +88,7 @@ class BiDi
         it 'can listen to any log' do
           reset_driver!(web_socket_url: true) do |driver|
             log_entry = nil
-            log_inspector = LogInspector.new(driver)
+            log_inspector = described_class.new(driver)
             log_inspector.on_log { |log| log_entry = log }
 
             driver.navigate.to url_for(@page)
@@ -104,7 +104,7 @@ class BiDi
         it 'can retrieve stack trace for a log' do
           reset_driver!(web_socket_url: true) do |driver|
             log_entry = nil
-            log_inspector = LogInspector.new(driver)
+            log_inspector = described_class.new(driver)
             log_inspector.on_javascript_log { |log| log_entry = log }
 
             driver.navigate.to url_for(@page)

rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb

@@ -34,9 +34,7 @@ module Chrome
         end
 
         it 'sets download path' do
-          driver.download_path = File.expand_path(__dir__)
-          # there is no simple way to verify that it's now possible to download
-          # at least it doesn't crash
+          expect { driver.download_path = File.expand_path(__dir__) }.not_to raise_exception
         end
 
         it 'can execute CDP commands' do
@@ -66,19 +64,19 @@ module Chrome
 
           let(:magic_number) { 'JVBER' }
 
-          it 'should return base64 for print command' do
+          it 'returns base64 for print command' do
             driver.navigate.to url_for('printPage.html')
             expect(driver.print_page).to include(magic_number)
           end
 
-          it 'should print with valid params' do
+          it 'prints with valid params' do
             driver.navigate.to url_for('printPage.html')
             expect(driver.print_page(orientation: 'landscape',
                                      page_ranges: ['1-2'],
                                      page: {width: 30})).to include(magic_number)
           end
 
-          it 'should save pdf' do
+          it 'saves pdf' do
             driver.navigate.to url_for('printPage.html')
 
             path = "#{Dir.tmpdir}/test#{SecureRandom.urlsafe_base64}.pdf"
@@ -112,26 +110,26 @@ module Chrome
 
             entries = driver.logs.get(:browser)
             expect(entries).not_to be_empty
-            expect(entries.first).to be_kind_of(LogEntry)
+            expect(entries.first).to be_a(LogEntry)
           end
 
           it 'can get the driver log' do
             entries = driver.logs.get(:driver)
             expect(entries).not_to be_empty
-            expect(entries.first).to be_kind_of(LogEntry)
+            expect(entries.first).to be_a(LogEntry)
           end
 
           it 'can get the performance log' do
             entries = driver.logs.get(:performance)
             expect(entries).not_to be_empty
-            expect(entries.first).to be_kind_of(LogEntry)
+            expect(entries.first).to be_a(LogEntry)
           end
         end
 
         it 'manages network features' do
           driver.network_conditions = {offline: false, latency: 56, download_throughput: 789, upload_throughput: 600}
           conditions = driver.network_conditions
-          expect(conditions['offline']).to eq false
+          expect(conditions['offline']).to be false
           expect(conditions['latency']).to eq 56
           expect(conditions['download_throughput']).to eq 789
           expect(conditions['upload_throughput']).to eq 600
@@ -150,7 +148,7 @@ module Chrome
           unless sinks.empty?
             device_name = sinks.first['name']
             driver.start_cast_tab_mirroring(device_name)
-            driver.stop_casting(device_name)
+            expect { driver.stop_casting(device_name) }.not_to raise_exception
           end
         end
 

rb/spec/integration/selenium/webdriver/chrome/profile_spec.rb

@@ -23,7 +23,7 @@ module Selenium
   module WebDriver
     module Chrome
       describe Profile, exclusive: {browser: :chrome} do
-        let(:profile) { Profile.new }
+        let(:profile) { described_class.new }
 
         it 'adds an extension' do
           ext_path = '/some/path.crx'

rb/spec/integration/selenium/webdriver/chrome/service_spec.rb

@@ -23,7 +23,7 @@ module Selenium
   module WebDriver
     module Chrome
       describe Service, exclusive: {browser: :chrome} do
-        let(:service) { Service.new }
+        let(:service) { described_class.new }
         let(:service_manager) { service.launch }
 
         after { service_manager.stop }

rb/spec/integration/selenium/webdriver/devtools_spec.rb

@@ -47,8 +47,8 @@ module WebDriver
         }.to raise_error(RuntimeError, "This is fine!")
       end
 
-      context 'authentication', except: {browser: :firefox,
-                                         reason: 'Fetch.enable is not yet supported'} do
+      describe '#register', except: {browser: :firefox,
+                                     reason: 'Fetch.enable is not yet supported'} do
         let(:username) { SpecSupport::RackServer::TestApp::BASIC_AUTH_CREDENTIALS.first }
         let(:password) { SpecSupport::RackServer::TestApp::BASIC_AUTH_CREDENTIALS.last }
 
@@ -152,8 +152,8 @@ module WebDriver
         expect(mutation.old_value).to eq('display:none;')
       end
 
-      context 'network interception', except: {browser: :firefox,
-                                               reason: 'Fetch.enable is not yet supported'} do
+      describe '#intercept', except: {browser: :firefox,
+                                      reason: 'Fetch.enable is not yet supported'} do
         it 'continues requests' do
           requests = []
           driver.intercept do |request, &continue|
@@ -202,7 +202,7 @@ module WebDriver
         end
       end
 
-      context 'script pinning', except: {browser: :firefox} do
+      describe '#pin_script', except: {browser: :firefox} do
         before do
           driver.navigate.to url_for('xhtmlTest.html')
         end