Skip to content

Commit c6da91f

Browse files
jess010p0deje
authored andcommitted
updated references to 'btnG' (deprecated) to 'btnK'
A number of legacy references to btnG exist within a variety of files throughout the repo. These have been replaced with current name of search button field on Google home page ('btnK) Could not raise issue through GitHub, but substance of it is this: Issue relates to legacy reference to 'btnG' which I gather used to be the name property assigned to the input for 'Google Search' HTML button used as an example throughout the repo. This has since updated to 'btnK' on Google's home page. Comments and examples need to be updated to reflect the change, or otherwise modified. Signed-off-by: Alex Rodionov <[email protected]>
1 parent 0b45ddb commit c6da91f

File tree

9 files changed

+72
-72
lines changed

9 files changed

+72
-72
lines changed

java/client/src/org/openqa/selenium/Keys.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
* Representations of pressable keys that aren't text. These are stored in the Unicode PUA (Private
2424
* Use Area) code points, 0xE000-0xF8FF.
2525
*
26-
* @see <a href="http://www.google.com.au/search?&amp;q=unicode+pua&amp;btnG=Search">http://www.google.com.au/search?&amp;q=unicode+pua&amp;btnG=Search</a>
26+
* @see <a href="http://www.google.com.au/search?&amp;q=unicode+pua&amp;btnK=Search">http://www.google.com.au/search?&amp;q=unicode+pua&amp;btnK=Search</a>
2727
*/
2828
public enum Keys implements CharSequence {
2929

java/client/test/com/thoughtworks/selenium/corebased/TestProxy.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public void testProxy() throws Exception {
3333
// // TODO(simon): Re-enable this test
3434
// selenium.open("http://www.google.com/");
3535
// selenium.type("q", "Selenium");
36-
// selenium.click("btnG");
36+
// selenium.click("btnK");
3737
// selenium.waitForPageToLoad("30000");
3838
}
3939
}

java/server/test/org/openqa/selenium/tests/GoogleTestSearch.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
</tr>
5050
<tr>
5151
<td>clickAndWait</td>
52-
<td>btnG</td>
52+
<td>btnK</td>
5353
<td>&nbsp;</td>
5454
</tr>
5555
<tr>

java/server/test/org/openqa/selenium/tests/TestProxy.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
</tr>
5959
<tr>
6060
<td>clickAndWait</td>
61-
<td>btnG</td>
61+
<td>btnK</td>
6262

6363
<td>&nbsp</td>
6464
</tr>

javascript/node/selenium-webdriver/lib/input.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const Button = {
3838
/**
3939
* Representations of pressable keys that aren't text. These are stored in
4040
* the Unicode PUA (Private Use Area) code points, 0xE000-0xF8FF. Refer to
41-
* http://www.google.com.au/search?&q=unicode+pua&btnG=Search
41+
* http://www.google.com.au/search?&q=unicode+pua&btnK=Search
4242
*
4343
* @enum {string}
4444
* @see <https://www.w3.org/TR/webdriver/#keyboard-actions>

javascript/selenium-core/scripts/ui-doc.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -129,15 +129,15 @@ <h3>Map Definitions File Syntax</h3>
129129

130130
map.addPageset({
131131
name: 'aPageset'
132-
, ...
132+
, ...
133133
});
134134
map.addElement('aPageset', { ... });
135135
map.addElement('aPageset', { ... });
136136
...
137137

138138
map.addPageset({
139139
name: 'anotherPageset'
140-
, ...
140+
, ...
141141
});
142142
...
143143
</pre>
@@ -155,7 +155,7 @@ <h3>Pageset Shorthand</h3>
155155
, pathRegexp: '.*'
156156
});
157157
</pre>
158-
158+
159159
<p>Here's a table containing information about the attributes of the Pageset object. The conditionally required or unrequired items are for IDE recording support only.</p>
160160

161161
<table>
@@ -695,7 +695,7 @@ <h3>Rollup Rules</h3>
695695
<tr><td>target</td>
696696
<td>Yes</td>
697697
<td>(String) a simplified regular expression string that matches the target of a command. Same rules as for the <code>command</code> attribute.</td>
698-
<td><pre>target: 'btnG'</pre>
698+
<td><pre>target: 'btnK'</pre>
699699
<pre>// special regexp characters must be
700700
// escaped in regexp strings. Backslashes
701701
// always need to be escaped in javascript

0 commit comments

Comments
 (0)