[js] Remove setLoggingPrefs from firefox.Option and safari.Options

Both of these methods were no-op holdovers from the legacy WebDriver
implementations that are no longer supported.

Author: jleyba

javascript/node/selenium-webdriver/CHANGES.md

@@ -67,6 +67,10 @@ mode.
    -  setDefaultFlow
    -  when (use Promise.resolve)
 *  Renamed `WebDriver#schedule()` to `WebDriver#execute()`
+*  Changes to `firefox.Options`
+   -  Removed setLoggingPreferences (was a no-op)
+*  Changes to `safari.Options`
+   -  Removed setLoggingPreferences (was a no-op)
 *  Changes to `lib/webdriver.Window` (`driver.manage().window()`):
    -   Added
        -  getRect

javascript/node/selenium-webdriver/firefox/index.js

@@ -130,7 +130,6 @@ const io = require('../io');
 const exec = require('../io/exec');
 const capabilities = require('../lib/capabilities');
 const command = require('../lib/command');
-const logging = require('../lib/logging');
 const webdriver = require('../lib/webdriver');
 const net = require('../net');
 const portprober = require('../net/portprober');
@@ -151,9 +150,6 @@ class Options {
     /** @private {!Array<string>} */
     this.args_ = [];
 
-    /** @private {logging.Preferences} */
-    this.logPrefs_ = null;
-
     /** @private {?capabilities.ProxyConfig} */
     this.proxy_ = null;
   }
@@ -231,16 +227,6 @@ class Options {
     throw TypeError('binary must be a string path or Channel object');
   }
 
-  /**
-   * Sets the logging preferences for the new session.
-   * @param {logging.Preferences} prefs The logging preferences.
-   * @return {!Options} A self reference.
-   */
-  setLoggingPreferences(prefs) {
-    this.logPrefs_ = prefs;
-    return this;
-  }
-
   /**
    * Sets the proxy to use.
    *
@@ -262,10 +248,6 @@ class Options {
     let firefoxOptions = {};
     caps.set('moz:firefoxOptions', firefoxOptions);
 
-    if (this.logPrefs_) {
-      caps.set(capabilities.Capability.LOGGING_PREFS, this.logPrefs_);
-    }
-
     if (this.proxy_) {
       caps.set(capabilities.Capability.PROXY, this.proxy_);
     }

javascript/node/selenium-webdriver/safari.js

@@ -26,7 +26,6 @@ const io = require('./io');
 const {Capabilities, Capability} = require('./lib/capabilities');
 const command = require('./lib/command');
 const error = require('./lib/error');
-const logging = require('./lib/logging');
 const promise = require('./lib/promise');
 const Symbols = require('./lib/symbols');
 const webdriver = require('./lib/webdriver');
@@ -78,9 +77,6 @@ class Options {
     /** @private {Object<string, *>} */
     this.options_ = null;
 
-    /** @private {./lib/logging.Preferences} */
-    this.logPrefs_ = null;
-
     /** @private {?./lib/capabilities.ProxyConfig} */
     this.proxy_ = null;
   }
@@ -106,10 +102,6 @@ class Options {
       options.setProxy(capabilities.get(Capability.PROXY));
     }
 
-    if (capabilities.has(Capability.LOGGING_PREFS)) {
-      options.setLoggingPrefs(capabilities.get(Capability.LOGGING_PREFS));
-    }
-
     return options;
   }
 
@@ -128,16 +120,6 @@ class Options {
     return this;
   }
 
-  /**
-   * Sets the logging preferences for the new session.
-   * @param {!./lib/logging.Preferences} prefs The logging preferences.
-   * @return {!Options} A self reference.
-   */
-  setLoggingPrefs(prefs) {
-    this.logPrefs_ = prefs;
-    return this;
-  }
-
   /**
    * Sets the proxy to use.
    *
@@ -173,9 +155,6 @@ class Options {
    */
   toCapabilities(opt_capabilities) {
     var caps = opt_capabilities || Capabilities.safari();
-    if (this.logPrefs_) {
-      caps.set(Capability.LOGGING_PREFS, this.logPrefs_);
-    }
     if (this.proxy_) {
       caps.set(Capability.PROXY, this.proxy_);
     }

javascript/node/selenium-webdriver/test/safari_test.js

@@ -40,14 +40,11 @@ describe('safari.Options', function() {
 
     it('extracts supported WebDriver capabilities', function() {
       let proxyPrefs = proxy.direct(),
-        logPrefs = {},
         caps = webdriver.Capabilities.chrome()
-          .set(webdriver.Capability.PROXY, proxyPrefs)
-          .set(webdriver.Capability.LOGGING_PREFS, logPrefs);
+          .set(webdriver.Capability.PROXY, proxyPrefs);
 
       let options = safari.Options.fromCapabilities(caps);
       assert(options.proxy_).equalTo(proxyPrefs);
-      assert(options.logPrefs_).equalTo(logPrefs);
     });
   });
 
@@ -73,16 +70,12 @@ describe('safari.Options', function() {
     });
 
     it('sets generic driver capabilities', function() {
-      let proxyPrefs = proxy.direct(),
-        loggingPrefs = {};
+      let proxyPrefs = proxy.direct();
 
-      options
-        .setLoggingPrefs(loggingPrefs)
-        .setProxy(proxyPrefs);
+      options.setProxy(proxyPrefs);
 
       let caps = options.toCapabilities();
       assert(caps.get('proxy')).equalTo(proxyPrefs);
-      assert(caps.get('loggingPrefs')).equalTo(loggingPrefs);
     });
   });
 });