[bazel + rust + ci]: Enable rust linting (#12722)

Author: shs96c

WORKSPACE

@@ -20,6 +20,7 @@ load("@apple_rules_lint//lint:setup.bzl", "lint_setup")
 # Add your linters here.
 lint_setup({
     "java-spotbugs": "//java:spotbugs-config",
+    "rust-rustfmt": "//rust:enable-rustfmt",
 })
 
 http_archive(

rust/BUILD.bazel

@@ -1,5 +1,9 @@
 load("@crates//:defs.bzl", "all_crate_deps")
-load("@rules_rust//rust:defs.bzl", "rust_binary", "rust_library", "rust_test", "rust_test_suite")
+load("//rust:defs.bzl", "rust_binary", "rust_library", "rust_test", "rust_test_suite", "rustfmt_config")
+
+rustfmt_config(
+    name = "enable-rustfmt",
+)
 
 # We want the release versions of Selenium to include the prebuilt
 # binaries, but if we're doing day-to-day dev work, then we should

rust/defs.bzl

@@ -0,0 +1,14 @@
+load(
+    "//rust/private:rustfmt_wrapper.bzl",
+    _rust_binary = "rust_binary",
+    _rust_library = "rust_library",
+    _rust_test = "rust_test",
+    _rust_test_suite = "rust_test_suite",
+)
+load("//rust/private:rustfmt_config.bzl", _rustfmt_config = "rustfmt_config")
+
+rust_binary = _rust_binary
+rust_library = _rust_library
+rust_test = _rust_test
+rust_test_suite = _rust_test_suite
+rustfmt_config = _rustfmt_config

rust/private/BUILD.bazel

@@ -0,0 +1,10 @@
+RustfmtConfig = provider()
+
+def _rust_config_impl(ctx):
+    return [
+        RustfmtConfig(),
+    ]
+
+rustfmt_config = rule(
+    _rust_config_impl,
+)

rust/private/rustfmt_config.bzl

@@ -0,0 +1,47 @@
+load("@apple_rules_lint//lint:defs.bzl", "get_lint_config")
+load(
+    "@rules_rust//rust:defs.bzl",
+    "rustfmt_test",
+    _rust_binary = "rust_binary",
+    _rust_library = "rust_library",
+    _rust_test = "rust_test",
+    _rust_test_suite = "rust_test_suite",
+)
+
+def _wrap_with_fmt_test(name, tags):
+    config = get_lint_config("rust-rustfmt", tags)
+    if config:
+        rustfmt_test(
+            name = "%s-fmt" % name,
+            targets = [
+                ":%s" % name,
+            ],
+            tags = [
+                "lint",
+                "rust-rustfmt",
+                "rustfmt",
+            ],
+        )
+
+def rust_library(name, **kwargs):
+    _rust_library(name = name, **kwargs)
+    _wrap_with_fmt_test(name, kwargs.get("tags", []))
+
+def rust_binary(name, **kwargs):
+    _rust_binary(name = name, **kwargs)
+    _wrap_with_fmt_test(name, kwargs.get("tags", []))
+
+def rust_test(name, **kwargs):
+    _rust_test(name = name, **kwargs)
+    _wrap_with_fmt_test(name, kwargs.get("tags", []))
+
+def rust_test_suite(name, srcs = [], **kwargs):
+    _rust_test_suite(name = name, srcs = srcs, **kwargs)
+    for src in srcs:
+        if not src.endswith(".rs"):
+            fail("srcs should have `.rs` extensions")
+
+        # Prefixed with `name` to allow parameterization with macros
+        # The test name should not end with `.rs`
+        test_name = name + "_" + src[:-3]
+        _wrap_with_fmt_test(test_name, kwargs.get("tags", []))

rust/private/rustfmt_wrapper.bzl

@@ -179,7 +179,6 @@ fn main() {
     }
     selenium_manager.set_logger(log);
 
-
     if cli.clear_cache || BooleanKey("clear-cache", false).get_value() {
         clear_cache(selenium_manager.get_logger(), &cache_path);
     }

rust/src/main.rs

@@ -15,3 +15,7 @@ bazel run //:buildifier
 section "Java"
 echo "    google-java-format" >&2
 find "$PWD/java" -type f -name '*.java' | xargs "$GOOGLE_JAVA_FORMAT" --replace
+
+section "Rust"
+echo "   rustfmt (fix with: bazel run @rules_rust//:rustfmt)" >&2
+bazel test //rust/... --test_tag_filters="rust-rustfmt" --build_tests_only