Skip to content

Commit d3603a8

Browse files
committed
Clean up guards for specs passing against Chrome
1 parent 488a97f commit d3603a8

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

rb/spec/integration/selenium/webdriver/options_spec.rb

+2-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ module WebDriver
3939
expect(driver.manage.logs.available_types).to include(:browser, :har)
4040
end
4141

42-
it 'can get the browser log', only: {browser: %i[firefox ff_esr]} do
42+
# TODO (Alex): Investigate why this spec passes on macOS but fails on Linux.
43+
it 'can get the browser log', only: {browser: %i[firefox ff_esr]}, except: {browser: :chrome, platform: :linux} do
4344
driver.navigate.to url_for('simpleTest.html')
4445

4546
entries = driver.manage.logs.get(:browser)

rb/spec/integration/selenium/webdriver/target_locator_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ module WebDriver
239239
expect(driver.title).to eq('Testing Alerts')
240240
end
241241

242-
it 'allows the user to dismiss an alert', except: {browser: :chrome, platform: :macosx} do
242+
it 'allows the user to dismiss an alert' do
243243
driver.navigate.to url_for('alerts.html')
244244
driver.find_element(id: 'alert').click
245245

@@ -307,7 +307,7 @@ module WebDriver
307307
expect { driver.title }.to raise_error(Selenium::WebDriver::Error::UnhandledAlertError)
308308
end
309309

310-
it 'raises an UnhandledAlertError if an alert has not been dealt with', only: {browser: :ff_esr} do
310+
it 'raises an UnhandledAlertError if an alert has not been dealt with', only: {browser: %i[chrome ff_esr]} do
311311
driver.navigate.to url_for('alerts.html')
312312
driver.find_element(id: 'alert').click
313313
wait_for_alert

0 commit comments

Comments
 (0)