Skip to content

Commit d37967a

Browse files
jimevansjimevans
committed
Updating .NET strong-named assembly build to correct package references
Fixes issue #5511.
1 parent 7dff24f commit d37967a

File tree

6 files changed

+145
-3
lines changed

6 files changed

+145
-3
lines changed

‎dotnet/src/support/BUCK

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ genrule(
120120

121121
genrule(
122122
name = 'pack_strongnamed',
123-
srcs = ['WebDriver.Support.nuspec'],
123+
srcs = ['WebDriver.Support.StrongNamed.nuspec'],
124124
cmd_exe = "$(exe //third_party/dotnet/nuget:nuget) pack %SRCS% /Properties packageid=Selenium.Support.StrongNamed;version={} /Version {} /BasePath $(location :merge_strongnamed) /OutputDirectory %OUT%".format(SE_VERSION, SE_VERSION),
125125
out = 'dist',
126126
visibility = [ 'PUBLIC' ]

‎dotnet/src/support/WebDriver.Support.StrongNamed.nuspec

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
3+
<metadata>
4+
<id>$packageid$</id>
5+
<version>$version$</version>
6+
<authors>Selenium Committers</authors>
7+
<copyright>Copyright © 2018 Software Freedom Conservancy</copyright>
8+
<owners>selenium</owners>
9+
<title>WebDriver Support</title>
10+
<requireLicenseAcceptance>false</requireLicenseAcceptance>
11+
<summary>Provides support classes for Selenium WebDriver</summary>
12+
<description>
13+
Selenium is a set of different software tools each with a different approach
14+
to supporting browser automation. These tools are highly flexible, allowing
15+
many options for locating and manipulating elements within a browser, and one
16+
of its key features is the support for automating multiple browser platforms.
17+
This package contains .NET support utilites and classes that users may find
18+
useful in using Selenium WebDriver. These support classes are mainly intended
19+
to spark ideas of what is possible with Selenium WebDriver, and may not be
20+
entirely appropriate for production use.
21+
</description>
22+
<projectUrl>https://www.seleniumhq.org</projectUrl>
23+
<repository url="https://github.com/SeleniumHQ/selenium" />
24+
<licenseUrl>http://www.apache.org/licenses/LICENSE-2.0</licenseUrl>
25+
<iconUrl>http://seleniumhq.org/images/big-logo.png</iconUrl>
26+
<tags>selenium webdriver support browser automation</tags>
27+
<dependencies>
28+
<group targetFramework=".NETFramework3.5">
29+
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
30+
</group>
31+
<group targetFramework=".NETFramework4.0">
32+
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
33+
</group>
34+
<group targetFramework=".NETFramework4.5">
35+
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
36+
</group>
37+
<group targetFramework=".NETStandard2.0">
38+
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
39+
</group>
40+
</dependencies>
41+
<frameworkAssemblies>
42+
<frameworkAssembly assemblyName="System.Drawing" />
43+
</frameworkAssemblies>
44+
</metadata>
45+
<files>
46+
<file src="**" target="lib" />
47+
</files>
48+
</package>

‎dotnet/src/webdriver/BUCK

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ genrule(
165165

166166
genrule(
167167
name = 'pack_strongnamed',
168-
srcs = ['WebDriver.nuspec'],
168+
srcs = ['WebDriver.StrongNamed.nuspec'],
169169
cmd_exe = "$(exe //third_party/dotnet/nuget:nuget) pack %SRCS% /Properties packageid=Selenium.WebDriver.StrongNamed /Version {} /BasePath $(location :merge_strongnamed) /OutputDirectory %OUT%".format(SE_VERSION),
170170
out = 'dist',
171171
visibility = [ 'PUBLIC' ]

‎dotnet/src/webdriver/WebDriver.StrongNamed.nuspec

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
3+
<metadata>
4+
<id>$packageid$</id>
5+
<version>$version$</version>
6+
<authors>Selenium Committers</authors>
7+
<copyright>Copyright © 2018 Software Freedom Conservancy</copyright>
8+
<owners>selenium</owners>
9+
<title>Selenium WebDriver</title>
10+
<requireLicenseAcceptance>false</requireLicenseAcceptance>
11+
<summary>.NET bindings for the Selenium WebDriver API</summary>
12+
<description>
13+
Selenium is a set of different software tools each with a different approach
14+
to supporting browser automation. These tools are highly flexible, allowing
15+
many options for locating and manipulating elements within a browser, and one
16+
of its key features is the support for automating multiple browser platforms.
17+
This package contains the .NET bindings for the concise and object-based
18+
Selenium WebDriver API, which uses native OS-level events to manipulate the
19+
browser, bypassing the JavaScript sandbox, and does not require the Selenium
20+
Server to automate the browser.
21+
</description>
22+
<projectUrl>https://www.seleniumhq.org</projectUrl>
23+
<repository url="https://github.com/SeleniumHQ/selenium" />
24+
<licenseUrl>http://www.apache.org/licenses/LICENSE-2.0</licenseUrl>
25+
<iconUrl>http://seleniumhq.org/images/big-logo.png</iconUrl>
26+
<tags>selenium webdriver browser automation</tags>
27+
<dependencies>
28+
<group targetFramework=".NETFramework3.5" />
29+
<group targetFramework=".NETFramework4.0" />
30+
<group targetFramework=".NETFramework4.5" />
31+
<group targetFramework=".NETStandard2.0">
32+
<dependency id="Newtonsoft.Json" version="10.0.3" exclude="Build,Analyzers" />
33+
</group>
34+
</dependencies>
35+
<frameworkAssemblies>
36+
<frameworkAssembly assemblyName="System.Drawing" />
37+
</frameworkAssemblies>
38+
</metadata>
39+
<files>
40+
<file src="**" target="lib" />
41+
</files>
42+
</package>

‎dotnet/src/webdriverbackedselenium/BUCK

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ genrule(
120120

121121
genrule(
122122
name = 'pack_strongnamed',
123-
srcs = ['Selenium.WebDriverBackedSelenium.nuspec'],
123+
srcs = ['Selenium.WebDriverBackedSelenium.StrongNamed.nuspec'],
124124
cmd_exe = "$(exe //third_party/dotnet/nuget:nuget) pack %SRCS% /Properties packageid=Selenium.WebDriverBackedSelenium.StrongNamed;version={} /Version {} /BasePath $(location :merge_strongnamed) /OutputDirectory %OUT%".format(SE_VERSION, SE_VERSION),
125125
out = 'dist',
126126
visibility = [ 'PUBLIC' ]

‎dotnet/src/webdriverbackedselenium/Selenium.WebDriverBackedSelenium.StrongNamed.nuspec

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
3+
<metadata>
4+
<id>$packageid$</id>
5+
<version>$version$</version>
6+
<authors>Selenium Committers</authors>
7+
<copyright>Copyright © 2017 Software Freedom Conservancy</copyright>
8+
<owners>selenium</owners>
9+
<title>WebDriver-backed Selenium</title>
10+
<requireLicenseAcceptance>false</requireLicenseAcceptance>
11+
<summary>Implementation of the Selenium Remote Control (RC) API, using WebDriver technology</summary>
12+
<description>
13+
Selenium is a set of different software tools each with a different approach
14+
to supporting browser automation. These tools are highly flexible, allowing
15+
many options for locating and manipulating elements within a browser, and one
16+
of its key features is the support for automating multiple browser platforms.
17+
This package contains the .NET bindings for the deprecated, more procedural
18+
Selenium Remote Control (or Selenium RC) API, but implemented using the current
19+
WebDriver technology. It does not require a running instance of the Selenium
20+
Server, and is not limited to the functionality available from within the
21+
JavaScript sandbox. It is intended as a transitional package to allow
22+
organizations with significant investment in the Selenium RC API to run their
23+
code with minimal modifications until they are able to migrate to the Selenium
24+
WebDriver API.
25+
</description>
26+
<projectUrl>https://www.seleniumhq.org</projectUrl>
27+
<repository url="https://github.com/SeleniumHQ/selenium" />
28+
<licenseUrl>http://www.apache.org/licenses/LICENSE-2.0</licenseUrl>
29+
<iconUrl>http://seleniumhq.org/images/big-logo.png</iconUrl>
30+
<tags>selenium webdriver remote control rc browser automation</tags>
31+
<dependencies>
32+
<group targetFramework=".NETFramework3.5">
33+
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
34+
</group>
35+
<group targetFramework=".NETFramework4.0">
36+
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
37+
</group>
38+
<group targetFramework=".NETFramework4.5">
39+
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
40+
</group>
41+
<group targetFramework=".NETStandard2.0">
42+
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
43+
</group>
44+
</dependencies>
45+
<frameworkAssemblies>
46+
<frameworkAssembly assemblyName="System.Drawing" />
47+
</frameworkAssemblies>
48+
</metadata>
49+
<files>
50+
<file src="**" target="lib" />
51+
</files>
52+
</package>

0 commit comments

Comments
 (0)