Don't swallow exceptions if unable to start safari

shs96c · shs96c · commit e867146d5067 · 2016-08-31T11:23:16.000+01:00
diff --git a/java/client/src/org/openqa/selenium/safari/SafariDriverService.java b/java/client/src/org/openqa/selenium/safari/SafariDriverService.java
@@ -51,8 +51,8 @@ public static SafariDriverService createDefaultService(SafariOptions options) {
   protected void waitUntilAvailable() throws MalformedURLException {
     try {
       PortProber.waitForPortUp(getUrl().getPort(), 20, SECONDS);
-    } catch (Exception e) {
-      e.printStackTrace();
+    } catch (RuntimeException e) {
+      throw new WebDriverException(e);
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,8 @@ public static SafariDriverService createDefaultService(SafariOptions options) {`
`51`	`51`	`protected void waitUntilAvailable() throws MalformedURLException {`
`52`	`52`	`try {`
`53`	`53`	`PortProber.waitForPortUp(getUrl().getPort(), 20, SECONDS);`
`54`		`- } catch (Exception e) {`
`55`		`- e.printStackTrace();`
	`54`	`+ } catch (RuntimeException e) {`
	`55`	`+ throw new WebDriverException(e);`
`56`	`56`	`}`
`57`	`57`	`}`
`58`	`58`