Fix getUri to insert "?" to uriQuery when necessary. #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requestBuilder function allows queryString of a Request not to begin with "?" character, and it inserts "?" when necessary. getUri should do the same thing. Otherwise applyCheckStatus in Network.Client.Core module can produce StatusCodeException with wrong URI in its "X-Request-URL" field in such a case. I encountered the problem with influxdb package.
snoyberg
added a commit
that referenced
this pull request
Jun 5, 2015
Fix getUri to insert "?" to uriQuery when necessary.
Owner
|
Good catch, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestBuilderfunction allowsqueryStringof aRequestnot to begin with "?" character, and it inserts "?" when necessary.getUrishould do the same thing. OtherwiseapplyCheckStatusinNetwork.Client.Coremodule can produceStatusCodeExceptionwith wrong URI in its "X-Request-URL" field in such a case. I encountered the problem with influxdb package.