Align withResponse and withResponseHistory's exception handling, and catch "resource vanished" #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
requested changes
Jan 30, 2022
Owner
snoyberg
left a comment
There was a problem hiding this comment.
LGTM. Can you add a changelog entry describing the improvement here? Thanks!
34e5145 to
e1169e3
Compare
Collaborator
Author
|
Added a Changelog. I'm a little bit unsure if this change isn't just papering over some deeper issues here. I can't really make sense of how connections that go away are (meant to be) dealt with. It also feels like this change breaks the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #479.