-
-
Notifications
You must be signed in to change notification settings - Fork 2
Removed AirflowDB #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed AirflowDB #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! There is still a conflict.
Co-authored-by: Malte Sander <[email protected]>
Thanks for reviewing! Conflict is resolved :) |
We decided we want to move database initialization into a separate Init Container (see stackabletech/superset-operator#404). Will add this to this PR shortly. |
Update: We decided against moving database initialization to an init container, since currently the logs of an init container don't get captured, if the init container fails. Database initialization stays in the scheduler container for now. Also, the CRD change was approved, so this could be merged I'd say. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Closes #259. As discussed in the issue, the scheduler takes care of the initialization of the database.
.spec.clusterConfig.databaseInitialization
(this was just to enable logging for the database initialization job, which doesn't exist anymore)kubectl rollout status --watch --timeout=5m statefulset/airflow-scheduler-default
Definition of Done Checklist