Add an additional case for clocks to sleep with a wallclock deadline #79139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
approved these changes
Feb 5, 2025
grynspan
reviewed
Feb 13, 2025
| case swift_clock_id_wall: | ||
| struct timespec wall; | ||
| #if defined(__linux__) || defined(__APPLE__) || defined(__wasi__) || defined(__OpenBSD__) || defined(__FreeBSD__) | ||
| clock_gettime(CLOCK_REALTIME, &wall); |
There was a problem hiding this comment.
timespec_get(&wall, TIME_UTC) is the C standard API for this and is supported on Windows too.
grynspan
reviewed
Feb 13, 2025
| case swift_clock_id_wall: { | ||
| struct timespec wall; | ||
| #if defined(__linux__) || defined(__APPLE__) || defined(__OpenBSD__) || defined(__FreeBSD__) || defined(__wasi__) | ||
| clock_getres(CLOCK_REALTIME, &wall); |
There was a problem hiding this comment.
As above, timespec_getres(&wall, TIME_UTC) is standard and works on Windows too.
1448d25 to
1c75060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only modifies the runtime function
swift_task_enqueueGlobalWithDeadlineto take new clock primitive to interoperate with dispatch's wall clock values.