[MacrosOnImports][Swiftify] Copy module imports from clang node's module to its Swift macro SourceFile #81859
+234
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5539cec to
7d2431e
Compare
|
@swift-ci please smoke test |
hnrklssn
commented
Jun 4, 2025
|
|
||
| // CHECK: import ModuleA | ||
| // CHECK-NEXT: import ModuleB | ||
| // CHECK-NOT: import |
There was a problem hiding this comment.
@DougGregor I don't fully get why only the module's imports that themselves are top-level modules show up in the dump. It seems to work regardless, but it seems a bit off. Do you know if this is intended?
7d2431e to
e5c5c6e
Compare
|
@swift-ci please smoke test |
e5c5c6e to
229280f
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows |
|
@swift-ci please smoke test |
Xazax-hun
reviewed
Jun 5, 2025
| // RUN: %target-swift-ide-test -print-module -module-to-print=ClangIncludesNoExportModule -plugin-path %swift-plugin-dir -I %S/Inputs -source-filename=x -enable-experimental-feature SafeInteropWrappers | %FileCheck %s | ||
|
|
||
| // swift-ide-test doesn't currently typecheck the macro expansions, so run the compiler as well | ||
| // RUN: %target-swift-frontend -emit-module -plugin-path %swift-plugin-dir -o %t/ClangIncludesNoExport.swiftmodule -I %S/Inputs -enable-experimental-feature SafeInteropWrappers %s |
There was a problem hiding this comment.
I think it would be nice to have a run line with C++ interop enabled just in case. Sometimes there are subtle differences between the two modes.
|
@swift-ci please smoke test |
When macros like _SwiftifyImport are added to a wrapper module for a clang module, they may need to refer to symbols declared in another clang module that the wrapped module imports (e.g. because they are used in the original signature). This adds all the imported clang modules as implicit imports to the wrapper module. rdar://151611573
1b8ba84 to
7c794aa
Compare
|
@swift-ci please smoke test macos |
7c794aa to
726d7b3
Compare
|
@swift-ci please smoke test macos |
726d7b3 to
b3c5489
Compare
|
@swift-ci please smoke test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the _SwiftifyImport peer macro expansion reuses the function signature of the original imported function, it needs to import the same modules as the module where the original clang node resides, to ensure visibility of any symbols that may appear in the signature.
rdar://151611573