Ignore .yalc/ folder when we publish to npm
#203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
approved these changes
May 4, 2019
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @nsthorat and @tafsiri)
aptlin
pushed a commit
to aptlin/tfjs-models
that referenced
this pull request
May 21, 2019
* upstream/master: Add ResNet50 for the PoseNet model (tensorflow#199) increase the version to 1.0.3 (tensorflow#207) replace XMLHttpRequest with tfjs-core util fetch (tensorflow#204) Correct a code block language (tensorflow#205) Correct a code block language (tensorflow#206) Ignore `.yalc/` folder when we publish to npm (tensorflow#203)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
.yalcto.npmignoreand update the version of coco-ssd so we can republish.We published coco-ssd with
.yalcwhich containsnode_modules, making the package size exceed 50mb. This results in jsdelivr failing to serve our bundles with the errorPackage size exceeded the configured limit of 50 MB.: https://cdn.jsdelivr.net/npm/@tensorflow-models/coco-ssd
I verified that all the other models are working.
This change is