Skip to content

Remove tf.ENV #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nsthorat opened this issue Sep 30, 2019 · 7 comments
Closed

Remove tf.ENV #2124

nsthorat opened this issue Sep 30, 2019 · 7 comments

Comments

@nsthorat
Copy link
Contributor

tf.ENV is a global mutable object that is exported from the module. This isn't allowed in ES2015 semantics and thus closure has problems with it.

Let's remove this in favor of tf.environment().

@rthadur
Copy link
Contributor

rthadur commented Oct 1, 2019

@nsthorat i see the PR got merged , can we close this issue or is there more request coming through ?

@nsthorat
Copy link
Contributor Author

nsthorat commented Oct 1, 2019

The PR that got merged is just introducing tf.env(), we won't be able to remove tf.ENV until we want to make a breaking change for TensorFlow.js 2.0 so let's keep this open.

@rthadur
Copy link
Contributor

rthadur commented Oct 1, 2019

sure , thanks for confirming

@gaikwadrahul8
Copy link
Contributor

Hi, @nsthorat

Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.

The TFJs team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TFJs version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.

Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow.js space.

Thank you for your support and cooperation.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This issue has been marked stale because it has no recent activity since 7 days. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale label Sep 8, 2023
@github-actions
Copy link

This issue was closed due to lack of activity after being marked stale for past 7 days.

@google-ml-butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants