Linters fail on master

[ivankorn]

Steps to reproduce:

1. git clone git@github.com:terraform-google-modules/terraform-google-container-vm.git
2. cd terraform-google-container-vm/
3. make -s

Expected result: exit code 0

Actual result: exit code 123

Console output:

[19:51][user@host:~/workspace/google/checks]$ git clone git@github.com:terraform-google-modules/terraform-google-container-vm.git
Cloning into 'terraform-google-container-vm'...
remote: Enumerating objects: 103, done.
remote: Counting objects: 100% (103/103), done.
remote: Compressing objects: 100% (78/78), done.
remote: Total 879 (delta 50), reused 57 (delta 23), pack-reused 776
Receiving objects: 100% (879/879), 170.96 KiB | 879.00 KiB/s, done.
Resolving deltas: 100% (492/492), done.
[19:51][user@host:~/workspace/google/checks]$ cd terraform-google-container-vm/
[19:51][user@host:~/workspace/google/checks/terraform-google-container-vm]$ make -s
Running shellcheck
Running flake8
./test/verify_boilerplate.py:66:15: N803 argument name 'ARGS' should be lowercase
./test/verify_boilerplate.py:195:28: N803 argument name 'ARGS' should be lowercase
Warning: compat_xargs -0 flake8 failed with exit code 123
Running go fmt and go vet
Running terraform fmt
terraform fmt -diff -check=true -write=false . 
terraform fmt -diff -check=true -write=false ./examples/instance_with_attached_disk 
terraform fmt -diff -check=true -write=false ./examples/managed_instance_group 
terraform fmt -diff -check=true -write=false ./examples/simple_instance 
terraform fmt -diff -check=true -write=false ./modules/cos-coredns 
terraform fmt -diff -check=true -write=false ./modules/cos-generic 
terraform fmt -diff -check=true -write=false ./modules/cos-mysql 
terraform fmt -diff -check=true -write=false ./test/fixtures/instance_with_attached_disk 

Error: Failed to read file test/fixtures/instance_with_attached_disk/terraform.tfvars


terraform fmt -diff -check=true -write=false ./test/fixtures/managed_instance_group 

Error: Failed to read file test/fixtures/managed_instance_group/terraform.tfvars


terraform fmt -diff -check=true -write=false ./test/fixtures/shared 
terraform fmt -diff -check=true -write=false ./test/fixtures/simple_instance 

Error: Failed to read file test/fixtures/simple_instance/terraform.tfvars


Warning: compat_xargs -t -n1 terraform fmt -diff -check=true -write=false failed with exit code 123
Error: terraform fmt failed with exit code 123
Check the output for diffs and correct using terraform fmt <dir>
make: *** [Makefile:44: check_terraform] Error 123
[19:51][user@host:~/workspace/google/checks/terraform-google-container-vm]$ 

[ivankorn]

Fixed linters introduced migration-related failures..
MIG example issue reported here #28
I'm going to log another issue to double-check TF 0.12 migration

cc: @nick4fake @Jberlinsky @morgante @aaron-lane @kopachevsky

~/workspace/google/checks/terraform-google-container-vm]$ make -s
Running shellcheck
Running flake8
Running go fmt and go vet
Running terraform fmt
terraform fmt -diff -check=true -write=false . 
terraform fmt -diff -check=true -write=false ./examples/instance_with_attached_disk 
terraform fmt -diff -check=true -write=false ./examples/managed_instance_group 
terraform fmt -diff -check=true -write=false ./examples/simple_instance 
terraform fmt -diff -check=true -write=false ./modules/cos-coredns 
terraform fmt -diff -check=true -write=false ./modules/cos-generic 
terraform fmt -diff -check=true -write=false ./modules/cos-mysql 
terraform fmt -diff -check=true -write=false ./test/fixtures/instance_with_attached_disk 
terraform fmt -diff -check=true -write=false ./test/fixtures/managed_instance_group 
terraform fmt -diff -check=true -write=false ./test/fixtures/shared 
terraform fmt -diff -check=true -write=false ./test/fixtures/simple_instance 
Running terraform validate
helpers/terraform_validate . 

Initializing provider plugins...

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.external: version = "~> 1.2"
* provider.google: version = "~> 2.12"

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
Success! The configuration is valid.

helpers/terraform_validate ./examples/instance_with_attached_disk 
Initializing modules...

Initializing provider plugins...

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.external: version = "~> 1.2"
* provider.google: version = "~> 2.12"

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
Success! The configuration is valid.

helpers/terraform_validate ./examples/managed_instance_group 
Initializing modules...

Initializing provider plugins...

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.external: version = "~> 1.2"
* provider.google: version = "~> 2.12"
* provider.null: version = "~> 2.1"

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

Error: Incorrect attribute value type

  on main.tf line 97, in resource "google_compute_firewall" "lb-to-instances":
  97:   source_ranges = [local.google_load_balancer_ip_ranges]

Inappropriate value for attribute "source_ranges": element 0: string required.


Error: Incorrect attribute value type

  on main.tf line 98, in resource "google_compute_firewall" "lb-to-instances":
  98:   target_tags   = [module.mig.target_tags]

Inappropriate value for attribute "target_tags": element 0: string required.


Error: Unsupported argument

  on .terraform/modules/http-lb/main.tf line 67, in resource "google_compute_ssl_certificate" "default":
  67:   lifecycle = {

An argument named "lifecycle" is not expected here.


Error: Unsupported argument

  on .terraform/modules/http-lb/main.tf line 86, in resource "google_compute_backend_service" "default":
  86:   backend         = ["${var.backends["${count.index}"]}"]

An argument named "backend" is not expected here. Did you mean to define a
block of type "backend"?


Error: Incorrect attribute value type

  on .terraform/modules/http-lb/main.tf line 107, in resource "google_compute_firewall" "default-hc":
 107:   target_tags   = ["${var.target_tags}"]

Inappropriate value for attribute "target_tags": element 0: string required.


Error: Incorrect attribute value type

  on .terraform/modules/mig/GoogleCloudPlatform-terraform-google-managed-instance-group-7550567/main.tf line 26, in resource "google_compute_instance_template" "default":
  26:   tags = ["${concat(list("allow-ssh"), var.target_tags)}"]

Inappropriate value for attribute "tags": element 0: string required.


Error: Unsupported argument

  on .terraform/modules/mig/GoogleCloudPlatform-terraform-google-managed-instance-group-7550567/main.tf line 33, in resource "google_compute_instance_template" "default":
  33:     access_config      = ["${var.access_config}"]

An argument named "access_config" is not expected here. Did you mean to define
a block of type "access_config"?


Error: Incorrect attribute value type

  on .terraform/modules/mig/GoogleCloudPlatform-terraform-google-managed-instance-group-7550567/main.tf line 52, in resource "google_compute_instance_template" "default":
  52:     scopes = ["${var.service_account_scopes}"]

Inappropriate value for attribute "scopes": element 0: string required.


Error: Incorrect attribute value type

  on .terraform/modules/mig/GoogleCloudPlatform-terraform-google-managed-instance-group-7550567/main.tf line 242, in resource "google_compute_firewall" "default-ssh":
 242:   source_ranges = ["${var.ssh_source_ranges}"]

Inappropriate value for attribute "source_ranges": element 0: string required.


Error: Incorrect attribute value type

  on .terraform/modules/mig/GoogleCloudPlatform-terraform-google-managed-instance-group-7550567/main.tf line 274, in resource "google_compute_firewall" "mig-health-check":
 274:   target_tags   = ["${var.target_tags}"]

Inappropriate value for attribute "target_tags": element 0: string required.

helpers/terraform_validate ./examples/simple_instance 
Initializing modules...

Initializing provider plugins...

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.external: version = "~> 1.2"
* provider.google: version = "~> 2.12"
* provider.random: version = "~> 2.2"

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
Success! The configuration is valid.

helpers/terraform_validate ./modules/cos-coredns 

Initializing provider plugins...

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.google: version = "~> 2.12"
* provider.template: version = "~> 2.1"

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

Error: Unsupported block type

  on main.tf line 37, in data "template_file" "cloud-config":
  37:   vars {

Blocks of type "vars" are not expected here. Did you mean to define argument
"vars"? If so, use the equals sign to assign it a value.


Error: Unsupported argument

  on main.tf line 76, in resource "google_compute_instance" "default":
  76:     access_config = {}

An argument named "access_config" is not expected here. Did you mean to define
a block of type "access_config"?


Error: Unsupported block type

  on main.tf line 84, in resource "google_compute_instance" "default":
  84:   metadata {

Blocks of type "metadata" are not expected here. Did you mean to define
argument "metadata"? If so, use the equals sign to assign it a value.

helpers/terraform_validate ./modules/cos-generic 

Initializing provider plugins...

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.google: version = "~> 2.12"
* provider.template: version = "~> 2.1"

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

Error: Unsupported block type

  on main.tf line 38, in data "template_file" "cloud-config":
  38:   vars {

Blocks of type "vars" are not expected here. Did you mean to define argument
"vars"? If so, use the equals sign to assign it a value.


Error: Unsupported argument

  on main.tf line 73, in resource "google_compute_instance" "default":
  73:     access_config = {}

An argument named "access_config" is not expected here. Did you mean to define
a block of type "access_config"?


Error: Unsupported block type

  on main.tf line 81, in resource "google_compute_instance" "default":
  81:   metadata {

Blocks of type "metadata" are not expected here. Did you mean to define
argument "metadata"? If so, use the equals sign to assign it a value.

helpers/terraform_validate ./modules/cos-mysql 

Initializing provider plugins...

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.google: version = "~> 2.12"
* provider.random: version = "~> 2.2"
* provider.template: version = "~> 2.1"

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

Error: Unsupported block type

  on main.tf line 46, in data "template_file" "cloud-config":
  46:   vars {

Blocks of type "vars" are not expected here. Did you mean to define argument
"vars"? If so, use the equals sign to assign it a value.


Error: Unsupported argument

  on main.tf line 101, in resource "google_compute_instance" "default":
 101:     access_config = {}

An argument named "access_config" is not expected here. Did you mean to define
a block of type "access_config"?


Error: Incorrect attribute value type

  on main.tf line 112, in resource "google_compute_instance" "default":
 112:     scopes = [compact(concat(

Inappropriate value for attribute "scopes": element 0: string required.


Error: Unsupported block type

  on main.tf line 118, in resource "google_compute_instance" "default":
 118:   metadata {

Blocks of type "metadata" are not expected here. Did you mean to define
argument "metadata"? If so, use the equals sign to assign it a value.

helpers/terraform_validate ./test/fixtures/instance_with_attached_disk 
Initializing modules...

Initializing provider plugins...

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.external: version = "~> 1.2"
* provider.google: version = "~> 2.12"
* provider.local: version = "~> 1.3"
* provider.random: version = "~> 2.2"
* provider.tls: version = "~> 2.0"

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
Success! The configuration is valid.

helpers/terraform_validate ./test/fixtures/managed_instance_group 
Initializing modules...

Initializing provider plugins...

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.external: version = "~> 1.2"
* provider.google: version = "~> 2.12"
* provider.local: version = "~> 1.3"
* provider.null: version = "~> 2.1"
* provider.random: version = "~> 2.2"
* provider.tls: version = "~> 2.0"

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

Error: Unsupported argument

  on .terraform/modules/example.http-lb/main.tf line 67, in resource "google_compute_ssl_certificate" "default":
  67:   lifecycle = {

An argument named "lifecycle" is not expected here.


Error: Unsupported argument

  on .terraform/modules/example.http-lb/main.tf line 86, in resource "google_compute_backend_service" "default":
  86:   backend         = ["${var.backends["${count.index}"]}"]

An argument named "backend" is not expected here. Did you mean to define a
block of type "backend"?


Error: Incorrect attribute value type

  on .terraform/modules/example.http-lb/main.tf line 107, in resource "google_compute_firewall" "default-hc":
 107:   target_tags   = ["${var.target_tags}"]

Inappropriate value for attribute "target_tags": element 0: string required.


Error: Incorrect attribute value type

  on .terraform/modules/example.mig/GoogleCloudPlatform-terraform-google-managed-instance-group-7550567/main.tf line 26, in resource "google_compute_instance_template" "default":
  26:   tags = ["${concat(list("allow-ssh"), var.target_tags)}"]

Inappropriate value for attribute "tags": element 0: string required.


Error: Unsupported argument

  on .terraform/modules/example.mig/GoogleCloudPlatform-terraform-google-managed-instance-group-7550567/main.tf line 33, in resource "google_compute_instance_template" "default":
  33:     access_config      = ["${var.access_config}"]

An argument named "access_config" is not expected here. Did you mean to define
a block of type "access_config"?


Error: Incorrect attribute value type

  on .terraform/modules/example.mig/GoogleCloudPlatform-terraform-google-managed-instance-group-7550567/main.tf line 52, in resource "google_compute_instance_template" "default":
  52:     scopes = ["${var.service_account_scopes}"]

Inappropriate value for attribute "scopes": element 0: string required.


Error: Incorrect attribute value type

  on .terraform/modules/example.mig/GoogleCloudPlatform-terraform-google-managed-instance-group-7550567/main.tf line 242, in resource "google_compute_firewall" "default-ssh":
 242:   source_ranges = ["${var.ssh_source_ranges}"]

Inappropriate value for attribute "source_ranges": element 0: string required.


Error: Incorrect attribute value type

  on .terraform/modules/example.mig/GoogleCloudPlatform-terraform-google-managed-instance-group-7550567/main.tf line 274, in resource "google_compute_firewall" "mig-health-check":
 274:   target_tags   = ["${var.target_tags}"]

Inappropriate value for attribute "target_tags": element 0: string required.


Error: Incorrect attribute value type

  on ../../../examples/managed_instance_group/main.tf line 97, in resource "google_compute_firewall" "lb-to-instances":
  97:   source_ranges = [local.google_load_balancer_ip_ranges]

Inappropriate value for attribute "source_ranges": element 0: string required.


Error: Incorrect attribute value type

  on ../../../examples/managed_instance_group/main.tf line 98, in resource "google_compute_firewall" "lb-to-instances":
  98:   target_tags   = [module.mig.target_tags]

Inappropriate value for attribute "target_tags": element 0: string required.

helpers/terraform_validate ./test/fixtures/simple_instance 
Initializing modules...

Initializing provider plugins...

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.external: version = "~> 1.2"
* provider.google: version = "~> 2.12"
* provider.random: version = "~> 2.2"

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
Success! The configuration is valid.

Warning: compat_xargs -t -n1 helpers/terraform_validate failed with exit code 123
make: *** [Makefile:44: check_terraform] Error 123