You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Originated by #331. I don't think no-node-access should report DOM elements queried from document since we can't detect properly if being used for a test because of Aggressive Reporting.
Additionally, seems this rule is too aggressive and could trigger tons of false positives outside test files, I think it's necessary to avoid Aggressive Reporting on this rule and make it reporting errors only if@testing-library/* or custom module set through Shared Settings imported.
This would make the previously mentioned invalid case doable. It could still cause some false negatives and silence some errors here and there, but I think it's necessary given how aggressive this rule is.
Belco90
changed the title
no-node-access should not report properties from document
limit no-node-access errors reported
Apr 13, 2021
Originated by #331. I don't think
no-node-access
should report DOM elements queried fromdocument
since we can't detect properly if being used for a test because of Aggressive Reporting.In the rule doc it says this case is invalid:
But we can't actually know this for the reason mentioned before.
The text was updated successfully, but these errors were encountered: