Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: freckle/yesod-auth-oauth2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.6.1.5
Choose a base ref
...
head repository: freckle/yesod-auth-oauth2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.6.1.6
Choose a head ref
  • 4 commits
  • 5 files changed
  • 1 contributor

Commits on Dec 10, 2020

  1. Brittany

    @pbrisbin
    pbrisbin committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    1f6d08d View commit details
    Browse the repository at this point in the history

  2. Support injecting fetchAccessToken 

    hoauth2's fetchAccessToken provides credentials in the Authorization
header, while fetchAccessToken2 provides them in that header but also
the POST body.

It was discovered that some providers only support one or the other, so
using fetchAccessToken2 would be preferred since it should work with
either. This happened in #129.

However, we discovered at least one provider (Okta) that actively
rejects requests unless they're supplying credentials in exactly one
place:

    Cannot supply multiple client credentials. Use one of the following:
    credentials in the Authorization header, credentials in the post
    body, or a client_assertion in the post body."

This patch reverts back to fetchAccessToken, but makes it possible to
for client to use fetchAccessToken2 if necessary via alternative
functions.
    @pbrisbin
    pbrisbin committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    bbda0d2 View commit details
    Browse the repository at this point in the history

  3. Version bump

    @pbrisbin
    pbrisbin committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    3cf4a3e View commit details
    Browse the repository at this point in the history

  4. Remove weeder from Makefile

    @pbrisbin
    pbrisbin committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    92bd62e View commit details
    Browse the repository at this point in the history
Loading