Github provider #10
Merged
Github provider #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and avoid authenticate 1.3.2.6 which gave the following strange error:
...
Building authenticate-1.3.2.6...
Preprocessing library authenticate-1.3.2.6...
[1 of 9] Compiling OpenId2.XRDS ( OpenId2/XRDS.hs, dist/dist-sandbox-a1429708/build/OpenId2/XRDS.o )
[2 of 9] Compiling Web.Authenticate.OpenId.Providers ( Web/Authenticate/OpenId/Providers.hs, dist/dist-sandbox-a1429708/build/Web/Authenticate/OpenId/Providers.o )
[3 of 9] Compiling Web.Authenticate.BrowserId ( Web/Authenticate/BrowserId.hs, dist/dist-sandbox-a1429708/build/Web/Authenticate/BrowserId.o )
Web/Authenticate/BrowserId.hs:15:22:
Module ‘Data.Conduit’ does not export ‘MonadBaseControl’
Web/Authenticate/BrowserId.hs:15:40:
Module ‘Data.Conduit’ does not export ‘MonadResource’
Failed to install authenticate-1.3.2.6
…n upgrade (hoauth2 0.4.1)'.)
…mails (the query to https://api.github.com/user return a null in the email field)
…l anyway have to be changed to include more queries)
|
Maybe @pbrisbin can take a look at it to tell us if it's okay to merge. |
|
I would need to have the email address of the user from github, and 'scopes' do need to be replaced by 'scope' in the authentication query, but I am not sure about the upgrade of authenticate > 1.3.2.6 is really needed (it just did not compiled on my machine). |
|
I'll be able to look at this on Friday. I'll pull it down, make sure it compiles in a clean sandbox, then release it. Since @cpennington 's commits are here and correctly attributed, I don't see any reason to merge #5 first. Thanks! |
|
I'd like to leave Pull Requests to you for now, @pbrisbin. I'm currently too far out of Haskell and don't have the time to get myself back into it for now. Sorry if it's an inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I would need the github provider.
I have rebased #5 onto master and done some minor corrections:
I've written a second query to fetch the email, corrected one typo (scope instead of scopes in the initial authentication query), and hardcoded the scope 'user:email'.
(I am not quite sure why #5 was not merged in the first place... )