Support windows

[koron]

I wrote these patches to support MS Windows.
After these patch, we can pass all tests by rake test on Windows.

---

Windows doesn't support which command.
And python 2.x binaries officially distributed for Windows don't include python2.exe.

[nitoyon]

👍

[comuttun]

@tmm1 Why is this not merged yet?
I've met this bug at Windows and the problem is fixed if I merge refs/pull/90/head locally.
current master with this is still all tests green.

[koistya]

I'm having this issue with Jekyll which many guys on forums relate to pygments.rb:

/posix-spawn-0.3.8/lib/posix/spawn.rb:162
warning: cannot close fd before spawn

Using pygments.rb v0.6.0

[garfieldnate]

Just a note that this is still an important issue for Jekyll and Octopress users.

[hickford]

Please merge! f03df35 broke pygments.rb—and all the software that depends on it—on Windows. That's upset several thousand Jekyll bloggers https://stackoverflow.com/questions/17364028/jekyll-on-windows-pygments-not-working

[avdv]

👍

Um, thinking about this again... Since you could install Python 2 and 3 side by side on Windows it would be no good idea to just blindly call the "python" binary. On Windows you could use the Python Launcher called as "py -2" which will spawn a Python 2 interpreter for you.

[koron]

Windows doesn't support which command as default.
And python 2.x binaries officially distributed for Windows don't include python2.exe.

[avdv]

Windows doesn't support which command as default.

Exactly.

And python 2.x binaries officially distributed for Windows don't include python2.exe.

True. But just calling "python" gets you the "default" Python interpreter which might be Python 3, and that will fail.

That's why I suggest to use the Python Launcher instead (which gets installed in %systemroot% and thus will always be found - regardless of the directories in %PATH%). The launcher will then figure out how to start a suitable Python interpreter by itself.

[koron]

But just calling "python" gets you the "default" Python interpreter which might be Python 3, and that will fail.

Incomplete is better than nothing.

[avdv]

Incomplete is better than nothing.

I disagree on that one. There's no point in fixing something, rolling out a release if you know in advance that it will not work (especially when you have a better solution).

Would you mind updating your pull request to use "py -2" please? Thanks!

[hickford]

@avdv If it helps, I've done that at #138 . I don't mind whom you pull, but let's fix Windows somehow.

[tmm1]

This was fixed in #138

[koron]

Thanks!