Skip to content

Commit 060028b

Browse files
manfred-colorfutorvalds
authored andcommitted
ipc/shm.c: increase the defaults for SHMALL, SHMMAX
System V shared memory a) can be abused to trigger out-of-memory conditions and the standard measures against out-of-memory do not work: - it is not possible to use setrlimit to limit the size of shm segments. - segments can exist without association with any processes, thus the oom-killer is unable to free that memory. b) is typically used for shared information - today often multiple GB. (e.g. database shared buffers) The current default is a maximum segment size of 32 MB and a maximum total size of 8 GB. This is often too much for a) and not enough for b), which means that lots of users must change the defaults. This patch increases the default limits (nearly) to the maximum, which is perfect for case b). The defaults are used after boot and as the initial value for each new namespace. Admins/distros that need a protection against a) should reduce the limits and/or enable shm_rmid_forced. Unix has historically required setting these limits for shared memory, and Linux inherited such behavior. The consequence of this is added complexity for users and administrators. One very common example are Database setup/installation documents and scripts, where users must manually calculate the values for these limits. This also requires (some) knowledge of how the underlying memory management works, thus causing, in many occasions, the limits to just be flat out wrong. Disabling these limits sooner could have saved companies a lot of time, headaches and money for support. But it's never too late, simplify users life now. Further notes: - The patch only changes default, overrides behave as before: # sysctl kernel.shmall=33554432 would recreate the previous limit for SHMMAX (for the current namespace). - Disabling sysv shm allocation is possible with: # sysctl kernel.shmall=0 (not a new feature, also per-namespace) - The limits are intentionally set to a value slightly less than ULONG_MAX, to avoid triggering overflows in user space apps. [not unreasonable, see http://marc.info/?l=linux-mm&m=139638334330127] Signed-off-by: Manfred Spraul <[email protected]> Signed-off-by: Davidlohr Bueso <[email protected]> Reported-by: Davidlohr Bueso <[email protected]> Acked-by: Michael Kerrisk <[email protected]> Acked-by: KOSAKI Motohiro <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 1376327 commit 060028b

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

include/linux/shm.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33

44
#include <asm/page.h>
55
#include <uapi/linux/shm.h>
6-
7-
#define SHMALL (SHMMAX/PAGE_SIZE*(SHMMNI/16)) /* max shm system wide (pages) */
86
#include <asm/shmparam.h>
7+
98
struct shmid_kernel /* private to the kernel */
109
{
1110
struct kern_ipc_perm shm_perm;

include/uapi/linux/shm.h

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,13 @@
99

1010
/*
1111
* SHMMAX, SHMMNI and SHMALL are upper limits are defaults which can
12-
* be increased by sysctl
12+
* be modified by sysctl.
1313
*/
1414

15-
#define SHMMAX 0x2000000 /* max shared seg size (bytes) */
1615
#define SHMMIN 1 /* min shared seg size (bytes) */
1716
#define SHMMNI 4096 /* max num of segs system wide */
18-
#ifndef __KERNEL__
19-
#define SHMALL (SHMMAX/getpagesize()*(SHMMNI/16))
20-
#endif
17+
#define SHMMAX (ULONG_MAX - (1L<<24)) /* max shared seg size (bytes) */
18+
#define SHMALL (ULONG_MAX - (1L<<24)) /* max shm system wide (pages) */
2119
#define SHMSEG SHMMNI /* max shared segs per process */
2220

2321

0 commit comments

Comments
 (0)