BS3: Navbar overhaul #9403
Merged
BS3: Navbar overhaul #9403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Now responsive by default (fits better with mobile-first approach) * Requires `.nav-header` to group `.navbar-brand` and `.navbar-toggle` for proper mobile display. * Changed `.nav-collapse` to `.navbar-collapse` * Simplified examples in docs
Conflicts: components.html dist/css/bootstrap.min.css
Member
Author
|
Also addresses #9303. |
Conflicts: dist/css/bootstrap.min.css
This was referenced Sep 23, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overhauls our navbars to address a few items:
.nav-headerto group.navbar-brandand.navbar-togglefor proper mobile display in conjunction with the collapsed content..nav-collapseto.navbar-collapsefor a more consistent naming convention.It can add some heft to an otherwise lightweight navbar, but I think all these improvements help the component and make it more durable in the long run. Still needs some finessing, but it's close I think.