Skip to content

Add warnings to the cabal file #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Add warnings to the cabal file #378

merged 1 commit into from
Feb 15, 2022

Conversation

aspiwack
Copy link
Member

This helps, in particular, when developping with ghcid, which
otherwise doesn't raise warnings.

I've had to deactivate cabal format in the formatting script due to
the fact that it inlines common stanzas, which I'm using to ensure
consistent warning settings in every target. See
haskell/cabal#5734.


I've written this while I was trying to do something smart with the
Elim and Make type classes. It didn't work. So there won't be a
followup PR, but this one is worth it on its own, I think.

This helps, in particular, when developping with ghcid, which
otherwise doesn't raise warnings.

I've had to deactivate `cabal` format in the formatting script due to
the fact that it inlines `common` stanzas, which I'm using to ensure
consistent warning settings in every target. See
[haskell/cabal#5734](haskell/cabal#5734).
@aspiwack aspiwack requested a review from tbagrel1 February 14, 2022 09:07
@tbagrel1
Copy link
Member

Well, I don't like the idea of removing cabal format (because it's nice to have alphabetically-sorted module names 😅 ); but adding common warnings seems to be more important. So let's do it (it's a pity that we don't have another solution at hand).

@aspiwack
Copy link
Member Author

it's a pity that we don't have another solution at hand

Yet…

Let's be on the lookout.

@aspiwack aspiwack merged commit 6993dee into master Feb 15, 2022
@aspiwack aspiwack deleted the activate-warnings branch February 15, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants