-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore(type-utils)!: remove IsNullableTypeOptions interface #8934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(type-utils)!: remove IsNullableTypeOptions interface #8934
Conversation
…typescript-eslint#8834) * feat(typescript-estree): remove slow deprecated and isolated programs * Update packages/typescript-estree/src/create-program/createProjectProgram.ts Co-authored-by: Brad Zacher <[email protected]> --------- Co-authored-by: Brad Zacher <[email protected]>
typescript-eslint#8920) * fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body * Fixed up tests and their snapshots * More about enums * Indent too * Update packages/ast-spec/src/special/TSEnumBody/spec.ts Co-authored-by: Brad Zacher <[email protected]> * parent types touchups * Update packages/visitor-keys/src/visitor-keys.ts Co-authored-by: Brad Zacher <[email protected]> --------- Co-authored-by: Brad Zacher <[email protected]>
Thanks for the PR, @thuchede! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
1a2afe5
to
6bd6595
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks! 🚀
Whoops, I forgot to add |
@JoshuaKGoldberg you also left the |
😬. |
We probably need to see if we can configure the PR title action to ban the |
#9789, too 📝 |
PR Checklist
Overview
Remove @deprecated
IsNullableTypeOptions
interface and its usage inisNullableType