Skip to content

chore(type-utils)!: remove IsNullableTypeOptions interface #8934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thuchede
Copy link
Contributor

PR Checklist

Overview

Remove @deprecated IsNullableTypeOptions interface and its usage in isNullableType

JoshuaKGoldberg and others added 2 commits April 15, 2024 10:56
…typescript-eslint#8834)

* feat(typescript-estree): remove slow deprecated and isolated programs

* Update packages/typescript-estree/src/create-program/createProjectProgram.ts

Co-authored-by: Brad Zacher <[email protected]>

---------

Co-authored-by: Brad Zacher <[email protected]>
typescript-eslint#8920)

* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body

* Fixed up tests and their snapshots

* More about enums

* Indent too

* Update packages/ast-spec/src/special/TSEnumBody/spec.ts

Co-authored-by: Brad Zacher <[email protected]>

* parent types touchups

* Update packages/visitor-keys/src/visitor-keys.ts

Co-authored-by: Brad Zacher <[email protected]>

---------

Co-authored-by: Brad Zacher <[email protected]>
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @thuchede!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@thuchede thuchede force-pushed the remove-is-nullable-type-options branch from 1a2afe5 to 6bd6595 Compare April 16, 2024 03:42
@thuchede thuchede changed the title chore!(type-utils): remove IsNullableTypeOptions interface chore(type-utils)!: remove IsNullableTypeOptions interface Apr 16, 2024
@auvred auvred added the breaking change This change will require a new major version to be released label Apr 19, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks! 🚀

@JoshuaKGoldberg JoshuaKGoldberg merged commit f4cbbe6 into typescript-eslint:v8 Apr 23, 2024
2 checks passed
@JoshuaKGoldberg
Copy link
Member

Whoops, I forgot to add BREAKING CHANGE: to the start of this PR's description. Noting to self that we'll need to manually edit this into the changelog.

@bradzacher
Copy link
Member

@JoshuaKGoldberg you also left the ! in the title which might break the semantic generator!

@JoshuaKGoldberg
Copy link
Member

😬.

@bradzacher
Copy link
Member

We probably need to see if we can configure the PR title action to ban the !

@JoshuaKGoldberg
Copy link
Member

#9027

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
@JoshuaKGoldberg
Copy link
Member

#9789, too 📝

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants