Use CString::new instead of CString::from_str to init chat template #683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what happened here but:
cargo build
fails for me on the currentmain
branch. It seems like CString doesn't implementfrom_str()
This PR just changes it to
CString::new()
which seems to have the same type signature and behavior.I guess it could be a thing about rust std versions?
My
rustup show
says the following, so it doesn't seem like I'm running anything unusual.I can't really explain why this works in your CI, but not on my machine- but it seems like a pretty uncontroversial change.