Skip to content

Conversation

@housseindjirdeh
Copy link
Contributor

Recent changes to next/script introduced the capability to use beforeInteractive scripts in the custom document. This old error message is incorrect.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to keep this document for older Next.js versions, we can add a link to the new doc if that helps?

@housseindjirdeh housseindjirdeh force-pushed the remove-no-script-in-document-error-doc branch from a031aeb to 54984ff Compare June 9, 2022 16:33
@housseindjirdeh housseindjirdeh force-pushed the remove-no-script-in-document-error-doc branch from 54984ff to 688232a Compare June 9, 2022 16:34
@housseindjirdeh
Copy link
Contributor Author

Ah good point. Updated it and included a note with a link to the new doc for folks using a newer Next.js version.

@housseindjirdeh housseindjirdeh changed the title [Script] Removes stale no-script-in-document-page error doc [Script] Updates stale no-script-in-document-page error doc Jun 9, 2022
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 2eb48e7 into vercel:canary Jun 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants