Skip to content

Fix hash mode deep links (#2125) #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Fix hash mode deep links (#2125) #2262

wants to merge 6 commits into from

Conversation

emanuelmutschlechner
Copy link
Contributor

@emanuelmutschlechner emanuelmutschlechner commented Jun 19, 2018 •
edited
Loading

Fixes #2125

@posva can you confirm it doesn't introduce some weird side effects?

@emanuelmutschlechner emanuelmutschlechner changed the title Fix hash mode deep links (2125) Fix hash mode deep links (#2125) Jun 19, 2018
@emanuelmutschlechner emanuelmutschlechner mentioned this pull request Jun 19, 2018
Closed
@posva
Copy link
Member

posva commented Jun 22, 2018

Thanks! This is not exactly it because we cannot just ignore the fallback option 😄 I'll have a look

@emanuelmutschlechner
Copy link
Contributor Author

emanuelmutschlechner commented Jun 23, 2018 •
edited
Loading

The fallback option isn't ignored in the router itself. Deep link fixes were only applied when the router did a fallback from history to hash mode in IE9?

https://github.com/gonoware/vuejs-vue-router/blob/dev/src/index.js#L44-L48

@persononomo
Copy link

@posva Hey, what I need to do for merging this PR. I need this )

@kolaente
Copy link

kolaente commented Nov 1, 2018

Any updates here? I'm looking forward to this.

posva added a commit that referenced this pull request Jul 16, 2019
@posva
fix(hash): corerctly place query if placed before hash
e84ebb1 
Fixes #2125
Closes #2262
@posva posva closed this in b7715dc Jul 16, 2019
@emanuelmutschlechner emanuelmutschlechner deleted the fix-hash-mode-deep-links branch July 16, 2019 17:53
This was referenced Aug 29, 2019
Open
Open
Closed
Open
@tt9133github tt9133github mentioned this pull request Sep 18, 2019
Open
This was referenced Sep 22, 2019
Merged
Open
Open
This was referenced Sep 30, 2019
Merged
Open
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
This was referenced Oct 26, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
This was referenced Jan 20, 2020
Merged
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 27, 2020
Closed
This was referenced Feb 5, 2020
Merged
Open
Merged
@tt9133github tt9133github mentioned this pull request Feb 14, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
This was referenced Mar 4, 2020
Open
Open
This was referenced Mar 24, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 3, 2020
Merged
This was referenced Apr 15, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hash mode places # at incorrect location in URL if current query parameters exist on page load
4 participants
@emanuelmutschlechner @posva @persononomo @kolaente